Add gh linter - fix issues in kubeops, asset-syncer and apprepo-ctrl #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Comment on lines
+14
to
+21
| ARG GOLANGCILINT_VERSION="1.46.2" | ||
|
|
||
| RUN curl -sfL https://raw.githubusercontent.com/securego/gosec/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v$GOSEC_VERSION | ||
| RUN go install github.com/golangci/golangci-lint/cmd/golangci-lint@v$GOLANGCILINT_VERSION | ||
|
|
||
| # Run golangci-lint to detect issues | ||
| RUN golangci-lint run --timeout=10m ./cmd/kubeops/... | ||
| RUN golangci-lint run --timeout=10m ./pkg/... |
There was a problem hiding this comment.
Why investing effort in Kubeops if will be removed (hopefully) soon?
There was a problem hiding this comment.
Mainly for consistency, but also, if want the github action to be run successfully, we need to fix any issue in the existing codebase. So, given that we would be removing the lining issues from Kubeops, why not add the linter in the building stage, as in the rest of go images?
There was a problem hiding this comment.
I'm not keen on investing effort in soon-to-be-dead code. Isn't it possible to exclude Kubeops part from any linting action?
castelblanque
approved these changes
Jul 12, 2022
antgamdia
added a commit
that referenced
this pull request
Jul 15, 2022
* Add golangci-lint gh action Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Increase timeout Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Remove wrongly commited file Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add linter to dockerfile Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add gh linter - fix issues in kubeops, asset-syncer and apprepo-ctrl (#5060) * Fix issues in kubeops Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix issues in assety-syncer Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix isses in apprepository-controller Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues (#5059) Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Add gh linter - fix issues in kubeappsapis (#5058) * Fix linter issues in test files Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix linter issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix issues Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix errata Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix lint issues and tests Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Comment out line as it is just being used by an in-progress unit test Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> * Fix test case Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR is aimed at fixing those issues in the
kubeops,asset-syncerandapprepo-ctrlcomponents. Some of them has been fixed and other, just marked asnolint.Benefits
Once we fix every issue, we will be able to merge the PR and therefore detect any linter issue before merging a PR.
Possible drawbacks
N/A
Applicable issues
Additional information
N/A