Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to delete Flux package in "pending" state #5538

Closed
gfichtenholt opened this issue Oct 21, 2022 · 4 comments · Fixed by #5549 or #5565
Closed

Unable to delete Flux package in "pending" state #5538

gfichtenholt opened this issue Oct 21, 2022 · 4 comments · Fixed by #5549 or #5565
Assignees
@antgamdia
Labels
component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux component/ui Issue related to kubeapps UI kind/bug An issue that reports a defect in an existing feature
Milestone
Technical debt

Comments

@gfichtenholt
Copy link
Contributor

gfichtenholt commented Oct 21, 2022 •
edited
Loading

I tried to deploy a flux package via UX.
The app failed to deploy for whatever reason (separate issue).
I would like to be able to delete this package but the UX won't let me. See attached screenshot

Also, I would like to know why it says "pending". There is nothing "pending" about it. The install is complete and was a failure.

Let me know if step-by-step reproduction instructions are needed I will be happy to provide.
Thanks

Screen Shot 2022-10-20 at 7 01 50 PM
@gfichtenholt gfichtenholt added the kind/bug An issue that reports a defect in an existing feature label Oct 21, 2022
@gfichtenholt gfichtenholt changed the title Unable to delete Flux package in pending state Unable to delete Flux package in "pending" state Oct 21, 2022
@gfichtenholt gfichtenholt added the component/ui Issue related to kubeapps UI label Oct 21, 2022
@ppbaena ppbaena added the component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux label Oct 21, 2022
@ppbaena ppbaena added this to the Technical debt milestone Oct 21, 2022
@antgamdia
Copy link
Contributor

I've also hit this issue in the past. Perhaps we should just allow removing apps in pending state (in fact, if you do so [by removing the disabled to the button in the browser inspector], it works).

Also, I would like to know why it says "pending". There is nothing "pending" about it. The install is complete and was a failure.

It is on the backend's plate: the pending status is part of the InstalledPkgDetail response. In fact, there is a reason being displayed on the left corner "failed to get last release revision". The Flux plugin should return a failed status, no?

So, I see two options here: either removing the disabled=true when a pending status is received OR we keep this behavior and perform the change in the plugin backend.

WDYT?

@gfichtenholt
Copy link
Contributor Author

gfichtenholt commented Oct 21, 2022 •
edited
Loading

yes to question 1, we should absolutely allow deleting apps in "pending" or "failed" state. I don't believe flux plugin restricts that.

question 2: is flux plugin issue, i verified. feel free to pass it to me when (1) is fixed. Thanks

@gfichtenholt gfichtenholt linked a pull request Oct 22, 2022 that will close this issue
Fixes for Optimize OCI repository lister lookups in flux plugin #5523 and Unable to delete Flux package in "pending" state #5538 #5549
Merged
gfichtenholt added a commit that referenced this issue Oct 24, 2022
@gfichtenholt
Fixes for Optimize OCI repository lister lookups in flux plugin #5523 …
c4466ce 
…and Unable to delete Flux package in "pending" state #5538  (#5549)

performance optimizations in flux plugin for OCI HelmRepositories and a
fix to mark the release failed instead of pending
@gfichtenholt
Copy link
Contributor Author

I've merged a fix for issue 2. re-opening to keep track of issue 1

@gfichtenholt gfichtenholt reopened this Oct 24, 2022
@gfichtenholt
Copy link
Contributor Author

the remaining issue is purely a UX change. Please re-assign accordingly. Thanks

@antgamdia antgamdia self-assigned this Oct 24, 2022
@antgamdia antgamdia mentioned this issue Oct 25, 2022
Merged
antgamdia added a commit that referenced this issue Oct 26, 2022
@antgamdia
Allow deleting pending pkgs (#5565)
fbf0791 
### Description of the change

As reported in #5538, sometimes, packages get stuck in a pending state.
Currently, Kubeapps UI was preventing the deletion of pending packages,
but this might not be a good solution if we really want to delete a
package.
It should be the backend that manages the deletion (or not) of a pending
package.

However, the tooltip is still being shown, this way users, at least,
will notice something is happening with this package.

### Benefits

No more pending packages stuck

### Possible drawbacks

N/A

### Applicable issues

- fixes #5538

### Additional information


![image](https://user-images.githubusercontent.com/11535726/197772089-1332fcf9-dcf3-4b0f-b7ca-a524a0ca08c6.png)


![image](https://user-images.githubusercontent.com/11535726/197772022-857f5f7c-fb56-4ad9-972e-f36a27259af4.png)

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@antgamdia antgamdia

Labels
component/plugin-flux Issue related to kubeapps plugin to manage Helm charts via Flux component/ui Issue related to kubeapps UI kind/bug An issue that reports a defect in an existing feature
Projects
Kubeapps
Archived in project
Milestone
Technical debt
3 participants
@ppbaena @antgamdia @gfichtenholt