Fix non-rendering chart if using extraHost or extraPaths
#3367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Sep 7, 2021
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
Sep 8, 2021
| --set ingress.enabled=true \ | ||
| --set ingress.hostname=example.com \ | ||
| bitnami/kubeapps | ||
| --set ingress.annotations."kubernetes\.io/ingress\.class"=nginx # or your preferred ingress controller |
There was a problem hiding this comment.
We should be using ingressClassName, but let's see what the Bitnami chart people think:
bitnami/charts#7434 (comment)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the changes proposed by @Mauraza at #3366 (comment) to fix the issue when rendering the Helm template.
Benefits
Our chart will work again :P
Possible drawbacks
N/A
Applicable issues
extraHosts#3366Additional information
We should commit these changes to the upstream chart repo as well.