Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versions - apprepository-controller #3449

Merged
merged 2 commits into from
Sep 21, 2021

Conversation

antgamdia
Copy link
Contributor

Description of the change

This PR adds the --version command to kubeops

Besides, it also adapts the code to the latest cobra boilerplate, so that all of our binaries are similar.

Benefits

Our binaries will properly display their version

Possible drawbacks

N/A

Applicable issues

Additional information

Testing with:

DOCKER_BUILDKIT=1 docker build -t kubeapps/apprepository-controller:dev --build-arg "VERSION=$(git rev-parse HEAD)" -f cmd/apprepository-controller/Dockerfile .

docker run  docker.io/kubeapps/apprepository-controller:dev ./apprepository-controller --version

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants