Add versions - pinniped-proxy #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
7 tasks
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Sep 21, 2021
cmd/pinniped-proxy/build.rs
Outdated
| // If the binary is built with the ENV var "PINNIPED_PROXY_VERSION", | ||
| // the value will be available at buildime. Otherwise, it becomes "devel" | ||
| // We use this ENV var to display a custom version when passing the "-- version" flag | ||
| let foo = env::var("PINNIPED_PROXY_VERSION").unwrap_or("devel".to_string()); |
There was a problem hiding this comment.
s/foo/version/ ?
And nice, hadn't read about bulid.rs - interesting interface to have for the build environment.
There was a problem hiding this comment.
Yep, right.
It is really interesting (https://doc.rust-lang.org/cargo/reference/build-scripts.html), it seems to be very promising. I still have to take a closer look a the docs, just to see if there is something else we can leverage from.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR adds the
--versioncommand topinniped-proxyBenefits
Our binaries will properly display their version
Possible drawbacks
N/A
Applicable issues
--versionto all of our binaries #3429Additional information
I have been also exploring vergen, but it gives us much more build/git/etc env information than we need.