-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release process docs #3555
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc changes look good, thanks. A couple of small comments.
Couldn't resist running prettier over the example js too :P, thanks.
docs/developer/release-process.md
Outdated
|
||
```bash | ||
# assuming you are in the main branch, with the latest changes pulled locally | ||
git checkout -b prerelease |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we're missing a step here to merge the main branch?
|
||
## 1.2 - Perform a manual test | ||
|
||
Even though we have a thorough test suite in our repository, we still _must_ perform a manual review of the application as it is in the selected commit. To do so, follow these instructions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the manual steps outlined, I'm unsure why we need to do this, given it's what we already check in CII. Or is it the installation in an additional cluster? So if we add a test for that, we can remove this manual check, or do you think it should always be done as a sanity check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, it's true... but even if the core functionality is being tested, we cannot guarantee the UI interactions are gonna work in the tagged release. I mean, what if Clarity UI now changes a header color? or the dependency in charge of rendering the markdown has a bug we haven't noticed?
Given the monthly release cadence we have, I think we can afford this manual test. At least, I'm personally more relaxed knowing it is working when some tests start crashing for no (known) reaso, haha.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Description of the change
As I'm executing the release process, I'm updating with the new steps after including the prerelease flow.
Benefits
Up to date guide
Possible drawbacks
N/A
Applicable issues
Additional information
N/A