Add GetInstalledPackageResourceRefs to packages API and implement in Helm. #3581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
absoludity
removed
the
stale
absoludity
force-pushed
the
3403-GetResourceRefs
branch
3 times, most recently
from
c899464
to
5f94523
Compare
absoludity
changed the title
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3403-GetResourceRefs
branch
from
47ced8f
to
b50109c
Compare
gfichtenholt
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Draft.
Adds the definition for a
GetInstalledPackageResourceRefsendpoint to the core.packaging API, with an implementation for the helm plugin and the aggregated core plugin. It's the more obvious part for the work in #3403.See the relevant section in the design doc which also links to the resources plugin function for getting the resources themselves.
Benefits
Each packaging plugin is able to return a Kubernetes GroupVersionKind and a name, uniquely identifying all resources created by an installed package.
Enables the further work so that the resources for an installed package can be fetched by clients (without requiring re-implementation by each packaging plugin, since it's not packaging specific).
Possible drawbacks
Applicable issues
GetK8sResourcesForInstalledPackage#3403Additional information