Fix for #3610 All other fluxv2 plugin operations must also support UX request with cluster #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
absoludity
approved these changes
Oct 21, 2021
| return &corev1.GetAvailablePackageSummariesResponse{ | ||
| AvailablePackageSummaries: packageSummaries, | ||
| NextPageToken: nextPageToken, | ||
| // TODO (gfichtenholt) Categories? | ||
| // Just happened to notice that helm plug-in returning this. | ||
| // Never discussed this and the design doc appears to have a lot of back-and-forth comments | ||
| // about this, semantics aren't very clear |
There was a problem hiding this comment.
Yes, we decided to return the categories so that we could finish the helm integration in the UX. It's not the best solution long-term but I think is OK right now. It's not so important, given that only the Bitnami repository defines categories like this, though if the bitnami repo becomes a main use-case for the flux plugin, we may want to include it.
| Name: "my-podinfo", | ||
| TargetContext: &corev1.Context{ | ||
| Namespace: "test-14", | ||
| Cluster: "this is not the cluster you're looking for", |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus previously discussed performance optimization for data flux plug stores in the cache
#3032 (comment)