Replace the unsafe gvk to gvr conversion with restmapper. #3775
Conversation
| // createRESTMapper returns a rest mapper configured with the APIs of the | ||
| // local k8s API server. This is used to convert between the GroupVersionKinds | ||
| // of the resource references to the GroupVersionResource used by the API server. | ||
| func createRESTMapper() (meta.RESTMapper, error) { |
There was a problem hiding this comment.
This is nuts... what an extra amount of coding for performing just a conversion...I guess I lack some K8s internal knowledge here, but I don't know why we need this kind of runtime information.
Thanks a lot for coming up with this solution (I don't know if the restmapper might be useful for additional things as well).
There was a problem hiding this comment.
It comes down to the fact that a client (kubectl or in our case our client-go client) cannot safely make assumptions about the mapping between an object (the yaml manifest with the GroupVersionKind) and the resource endpoint in the API. The only safe way to determine the mapping is to query the api server for the API information, which is what this now does.
| // For testing, define a kindToResource converter that doesn't require | ||
| // a rest mapper. | ||
| kindToResource: func(mapper meta.RESTMapper, gvk schema.GroupVersionKind) (schema.GroupVersionResource, error) { | ||
| gvr, _ := meta.UnsafeGuessKindToResource(gvk) |
There was a problem hiding this comment.
Great, at least the unsafe thing is still useful :P
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3403-GetResources-4
branch
from
e6d6a49
to
a087c12
Compare
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Who would have thought converting from the GroupVersionKind of a yaml resource to the GroupVersionResource required by the API server would be so arduous?!
This PR replaces the unsafe conversion that was used temporarily, instead initializing a RESTMapper from the APIserver (using the service account) at startup and switching to use that at run-time for the conversion.
Follows on from #3767
Benefits
We don't depend on known-to-be-unsafe code.
Possible drawbacks
Applicable issues
GetK8sResourcesForInstalledPackage#3403Additional information