Update resources plugin to support resource refs with namespace. #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antgamdia
reviewed
Nov 19, 2021
| @@ -198,7 +198,12 @@ func (s *Server) GetResources(r *v1alpha1.GetResourcesRequest, stream v1alpha1.R | |||
| } | |||
|
|
|||
| if !r.GetWatch() { | |||
| resource, err := dynamicClient.Resource(gvr).Namespace(namespace).Get(stream.Context(), ref.GetName(), metav1.GetOptions{}) | |||
| var resource interface{} | |||
| if ref.Namespace != "" { | |||
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-add-namespace-to-ref
branch
from
cbfc108
to
3f33ab3
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-use-namespace-in-resources-plugin
branch
from
f6dffc7
to
51b1766
Compare
absoludity
force-pushed
the
3779-add-namespace-to-ref
branch
from
3f33ab3
to
21d63cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Follows #3781 and updates the resources plugin itself to support the namespace field in a resource ref.
This means the plugin is now able to get or watch resources from a namespace other than that of the installed package - as long as it belongs to the installed package.
It also makes it much cleaner to handle non-namespaced resources since it's simply depends on whether the resource ref has a namespace (hmm, actually, we've had non-namespaced resources in the kubeapps chart where we've specified the namespace, so we'll still need to ensure, server-side, that the resource is namespaced or not).
Benefits
See benefits of #3781
Possible drawbacks
Applicable issues
Additional information