Support for list resources in GetInstalledPackageResourceRefs #3795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absoludity
added a commit
that referenced
this pull request
Nov 22, 2021
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-use-namespace-in-resources-plugin
branch
from
f6dffc7
to
51b1766
Compare
antgamdia
approved these changes
Nov 22, 2021
Base automatically changed from
3779-use-namespace-in-resources-plugin
to
master
November 23, 2021 00:24
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
3779-extra-yaml-parsing-cases
branch
from
13c07ce
to
227fff7
Compare
absoludity
added a commit
that referenced
this pull request
Nov 23, 2021
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
added a commit
that referenced
this pull request
Nov 23, 2021
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
added a commit
that referenced
this pull request
Nov 24, 2021
* Update dashboard to fetch resource refs via API. Signed-off-by: Michael Nelson <minelson@vmware.com> * Remove TODO after rebasing on #3795 Signed-off-by: Michael Nelson <minelson@vmware.com> * Remove debug test. Signed-off-by: Michael Nelson <minelson@vmware.com> * Lint Signed-off-by: Michael Nelson <minelson@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
While removing code from the dashboard in #3794, I found that the dashboard was handling some extra cases of
Listresources that had not been included in the helm plugin's GetInstalledPackageResourceRefs.This PR addresses those and I'll rebase 3794 on this.
Benefits
Avoid a regression when switching to the api server endpoint.
Possible drawbacks
Applicable issues
Additional information