Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused feature flag. Remove use of batch/v1beta1 #3828

Merged
merged 1 commit into from
Nov 25, 2021

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Just fixes two small issues I noticed while investigating #3818.

The logs of the app-repository controller are currently just:

W1125 09:05:48.815213       1 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob
W1125 22:06:10.357233       1 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob
W1125 22:14:02.224164       1 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob
W1125 22:20:29.230197       1 warnings.go:70] batch/v1beta1 CronJob is deprecated in v1.21+, unavailable in v1.25+; use batch/v1 CronJob

and the functionality behind the invalidateCache feature flag has been removed so the flag does nothing which is confusing.

Benefits

One less thing to worry about when running on Kubernetes 1.25+

Possible drawbacks

None that I can see.

Applicable issues

  • fixes #

Additional information

Signed-off-by: Michael Nelson <minelson@vmware.com>
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks! Love housekeeping! :P

@absoludity
Copy link
Contributor Author

Awesome! Thanks! Love housekeeping! :P

Indeed :) Just unsure if you want things like this landed (assuming it passes CI) or should we now wait until you've tagged things tomorrow. Fine either way for me.

@antgamdia
Copy link
Contributor

Yes! Let's land, we haven't performed anything wrt the release (we still have to test it thoroughly, etc), so it's totally ok with me.

@absoludity absoludity merged commit 7e30417 into vmware-tanzu:master Nov 25, 2021
@absoludity absoludity deleted the remove-batch/v1beta1 branch November 25, 2021 23:33
antgamdia pushed a commit that referenced this pull request Nov 26, 2021
@antgamdia
Copy link
Contributor

antgamdia commented Nov 26, 2021

Yesterday I didn't notice we still do support k8s 1.20, so we can't upgrade the CronJob to the latest version w/o causing problems in this version.
https://kubernetes.io/blog/2021/04/09/kubernetes-release-1.21-cronjob-ga/

I'll send a PR partially reverting this one, as well as adding some minor fixes for CI (kubeops-related)

antgamdia added a commit that referenced this pull request Nov 26, 2021
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity pushed a commit that referenced this pull request Nov 29, 2021
* Partially revert remove use of batch/v1beta1 (#3828)

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

* Add kubeops.enabled flag in CI

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants