Upgrade dependencies #4121
Merged
Upgrade dependencies #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: go.sum
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/yarn.lock go.mod go.sum
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
commented
Jan 24, 2022
| @@ -2,37 +2,37 @@ version: 2.1 | |||
| parameters: | |||
| GOLANG_VERSION: | |||
| type: string | |||
| default: "1.17.3" | |||
| default: "1.17.5" | |||
There was a problem hiding this comment.
CircleCI hasn't pushed the 1.17.6 yet
| @@ -25,7 +25,7 @@ import ( | |||
| "github.com/heptiolabs/healthcheck" | |||
| "github.com/kubeapps/kubeapps/cmd/assetsvc/pkg/utils" | |||
| "github.com/kubeapps/kubeapps/pkg/dbutils" | |||
| "github.com/urfave/negroni" | |||
| negroni "github.com/urfave/negroni/v2" | |||
There was a problem hiding this comment.
They created a tag and started using the v2 version, but there aren't any breaking changes.
However, since snyk detects a vulnerability here, I've performed this change now so that, in the future, when dependabot creates a PR, it'll be just a matter of accepting the PR)
| @@ -48,6 +48,6 @@ plugins: | |||
| opt: | |||
| - outputClientImpl=grpc-web # client implementation it generates | |||
| - esModuleInterop=true # use imports as required in modern ts setups | |||
| - useOptionals=true # use optional TypeScript properties instead of undefined | |||
| - useOptionals=messages # use optional TypeScript properties instead of undefined | |||
There was a problem hiding this comment.
I got a deprecation message here saying true will be no longer accepted in upcoming versions. The drop-in replacement is messages as they mentioned in their docs.
Comment on lines
-80
to
-82
| "@types/enzyme-adapter-react-16": "^1.0.6", | ||
| "@types/google-protobuf": "^3.15.5", |
There was a problem hiding this comment.
Removing unused dev dependencies
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: dashboard/Dockerfile
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com> Conflicts: cmd/pinniped-proxy/Cargo.lock dashboard/package.json
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
As part of the upcoming release, this PR is aimed at performing a general update on the dependencies we use.
Benefits
Up to date deps.
Possible drawbacks
Some unnoticed breaking changes? Let our beloved CI speak up.
Applicable issues
N/A
Additional information
If you, locally, face some weird issues when running the
yarn testcommand, just runyarn test --clearCacheand thenyarn testThis PR depends on #4137