Add step in the release docs #4290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Feb 16, 2022
|
|
||
| Eventually, as the Kubeapps code continues to evolve, some changes are often introduced in our own [development container images](https://hub.docker.com/u/kubeapps). However, those changes won't get released in the official Bitnami repository unless we manually notify the proper team to also include those changes in their building system. | ||
|
|
||
| > As part of this release process, each Kubeapps component's Dockerfile _must_ compared against the one in the previous release. If they functionally differ each other, the Bitnami Content team _must_ be notified. |
There was a problem hiding this comment.
Thanks Antonio. Can we even compare them, or is this something we need to ask the Bitnami content team to do? I tried yesterday to find the Dockerfile, but only found a Dockerfile which pulls a tar.gz and expands it... so quite opaque.
There was a problem hiding this comment.
We can compare them with the internal gitlist tool, but yep, we wouldn't find a Dockerfile as is, but a kind of "recipe" with their way to build the image. Then we would have to figure out if these recipe steps match our Dockerfile; so it is really a manual process likely to be performed by the proper team.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Due to our recent problems with the release, this PR just adds another step to ensure we double-check our new dockerfiles against the latest release's ones.
Benefits
We (hopefully) won't forget this step anymore when releasing.
Possible drawbacks
Still manual and therefore error-prone, but... nothing more we can do :S
Applicable issues
N/A
Additional information
N/A