-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add carvel test to e2e #4489
Add carvel test to e2e #4489
Conversation
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
This is CircleCI killing the process as it has >10m without any output, as the message suggests. Deployments timeout is set to await page.waitForSelector("css=.application-status-pie-chart-number >> text=1", {
timeout: utils.getDeploymentTimeout(),
});
await page.waitForSelector("css=.application-status-pie-chart-title >> text=Ready", {
timeout: utils.getDeploymentTimeout(),
}); Could it be related to #4447 ? The pie chart not being refreshed. A different issue would be to investigate why the deployment timeout is calculated as |
Just for the record, if we ever want to increase the no-output timeout (I don't think it is worth for this particular issue), it can be done in CircleCI with |
Yep, I realise, just unsure why it happens like that on CI but locally I see more output.
Again, locally I see the pie chart for this one (why I chose it - the issue with #4447 was that the resource refs only included CRDs, not deployments, in the packages I was trying, so we never watched for the resources, hence no pie chart).
Heh, fun. |
Signed-off-by: Michael Nelson <minelson@vmware.com>
The issue was that the check was looking for the pie chart showing 1 pod ready. The carvel package I'm testing with produces 3 pods. It passed locally because one pod came up (and the page updated) before the others came up (and it updated again, but the test had already succeeded). Let's see if it passes here now. |
sigh - still something different in the CI env than from locally where it passes :/ |
Signed-off-by: Michael Nelson <minelson@vmware.com>
Hah - so locally I was running with a service account login, which meant that the namespace was defaulting to the kubeapps namespace (since the service account token was from there), where the service account |
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Carvel test is now passing, just trying to ensure that we don't re-enable packaging.helm when upgrading to support operators, since it causes issues re-installing postgres with the password. |
Woo - and it's ready to land :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!! It's great we finally have Carvel e2e support, thanks!
script/e2e-test.sh
Outdated
@@ -18,6 +18,7 @@ DOCKER_PASSWORD=${6:-""} | |||
TEST_TIMEOUT_MINUTES=${7:-4} | |||
DEX_IP=${8:-"172.18.0.2"} | |||
ADDITIONAL_CLUSTER_IP=${9:-"172.18.0.3"} | |||
KAPP_CONTROLLER_VERSION="v0.32.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmm, perhaps we should pass this var also from the circleci config, like we already do for the OLM_VERSION
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops, yes. Forgot to update it. Done.
Cool!! Great to see it passes OK in CI. |
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
See #4093
Benefits
We can have CI checking that as a minimum a simple carvel install works.
Possible drawbacks
Longer CI? We should parallelize the helm and carvel tests.
Applicable issues
Additional information
Creating as draft until CI passes.
Currently failing on CI with:
even though locally it gets past this point.
Feel free to review. I'll try to get it passing tomorrow.