Update deps for the release process. #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
commented
Mar 30, 2022
Comment on lines
-69
to
-102
| ### 0.3 - Development chart | ||
|
|
||
| Even though the official [Bitnami chart](https://github.com/bitnami/charts/tree/master/bitnami/kubeapps) is automatically able to retrieve the latest dependency versions, we still need to sync the versions declared in our own development chart. | ||
|
|
||
| #### 0.3.1 - Chart images | ||
|
|
||
| Currently, the [values.yaml](../../chart/kubeapps/values.yaml) uses the following container images: | ||
|
|
||
| - [bitnami/nginx](https://hub.docker.com/r/bitnami/nginx/tags) | ||
| - [bitnami/oauth2-proxy](https://hub.docker.com/r/bitnami/oauth2-proxy/tags) | ||
|
|
||
| > As part of this release process, these image tags _must_ be updated to the latest minor version. In case of a major version, the change _should_ be tracked in a separate PR. | ||
|
|
||
| #### 0.3.2 - Chart dependencies | ||
|
|
||
| The chart [dependencies](../../chart/kubeapps/Chart.yaml) _must_ be checked to ensure the version includes the latest dependent charts. | ||
|
|
||
| - Check if the latest versions are already included by running: | ||
|
|
||
| ```bash | ||
| helm dep list ./chart/kubeapps | ||
| ``` | ||
|
|
||
| - If they are not, run this other command to update the `requirements.lock` file: | ||
|
|
||
| ```bash | ||
| # It requires Helm >=3.7.0, otherwise, just run `helm dep update ./chart/kubeapps` | ||
| helm repo update bitnami | ||
| helm dep update --skip-refresh ./chart/kubeapps | ||
| ``` | ||
|
|
||
| > As part of this release process, the chart dependencies _must_ be updated to the latest versions. In case of a major version, the change _should_ be tracked in a separate PR. | ||
|
|
||
| ### 0.4 - Protobuf dependencies and autogenerated code |
There was a problem hiding this comment.
I've removed this section because we get this automatically from the merges of the bitnami chart now, don't we?
There was a problem hiding this comment.
I think so. In the last 2-3 days we have received from Bitnami almost 1 chart update per day.
|
This PR covers the whole step 0 of release process document, right? |
castelblanque
approved these changes
Mar 30, 2022
Yep, except that I used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Updates a bunch of deps following our release instructions. Also removes some notes in those instructions that I think are no longer necessary.
Benefits
Possible drawbacks
Applicable issues
Additional information