bootstap new apprepository-controller with files auto-generated by kubebuilder #4731
Conversation
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -0,0 +1,27 @@ | |||
| # Build the manager binary | |||
| FROM golang:1.17 as builder | |||
There was a problem hiding this comment.
I'd rather use the bitnami image for consistency:
| FROM golang:1.17 as builder | |
| FROM bitnami/golang:1.18.2 as builder |
|
|
||
| # Use distroless as minimal base image to package the manager binary | ||
| # Refer to https://github.com/GoogleContainerTools/distroless for more details | ||
| FROM gcr.io/distroless/static:nonroot |
There was a problem hiding this comment.
Don't know whether or not we should this img from google or just FROM scratch as we are doing in the rest of Dockerfiles. I'd rather go with the latter unless there is any reason to use the google one.
| // Copyright XXXX-YYYY the Kubeapps contributors. | ||
| // SPDX-License-Identifier: Apache-2.0 |
There was a problem hiding this comment.
I guess this PR is just for the autogenerated code, but just a heads up not to forget to update the copyright year like:
// Copyright 2022 the Kubeapps contributors.`
// SPDX-License-Identifier: Apache-2.0
| spec: | ||
| containers: | ||
| - name: kube-rbac-proxy | ||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.11.0 |
There was a problem hiding this comment.
At some point, we might need to add this version to the release-process.md document in which we periodically look for updates
| @@ -0,0 +1,74 @@ | |||
| module github.com/vmware-tanzu/kubeapps | |||
|
|
|||
| go 1.17 | |||
There was a problem hiding this comment.
I guess this file should be at the root level instead (for the sake of consistency with the rest of the go code we have)
| /* | ||
| Copyright 2022. | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ |
There was a problem hiding this comment.
| /* | |
| Copyright 2022. | |
| Licensed under the Apache License, Version 2.0 (the "License"); | |
| you may not use this file except in compliance with the License. | |
| You may obtain a copy of the License at | |
| http://www.apache.org/licenses/LICENSE-2.0 | |
| Unless required by applicable law or agreed to in writing, software | |
| distributed under the License is distributed on an "AS IS" BASIS, | |
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |
| See the License for the specific language governing permissions and | |
| limitations under the License. | |
| */ | |
| // Copyright 2022 the Kubeapps contributors. | |
| // SPDX-License-Identifier: Apache-2.0 |
| @@ -0,0 +1,99 @@ | |||
| These are the commands I ran after bootstrapping kubebuilder locally per | |||
There was a problem hiding this comment.
Great, thanks!
At some point, it'd be great if this file gets converted into a markdown-based one.
There was a problem hiding this comment.
agreed. at some point 😄 right now I just want to plow ahead, there is a lot of changes to come in
This PR only contains files auto-generated by kubebuilder tool, i.e. the changes are mechanical.
The commands I ran to get here are in script.txt
Next: will be manual modifications of cmd/apprepository-controller-new/api/v1alpha2/apprepository_types.go to match the schema I want to have