Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Namespace: add static labels to namespace #4956

Merged
merged 8 commits into from
Jul 15, 2022

Conversation

smerschjohann
Copy link
Contributor

This change adds the ability to add labels to namespaces during creation. These labels can be configured in the config.json of the dashboard.

Description of the change

  • Added labels to the grpc proto of the resources.proto
  • passed these labels to the Kubernetes Manifest
  • added createNamespaceLabels to the Dashboard configuration
  • passed these values to the "createNamespace" method
  • added the newly introduced config parameter to the Helm-Chart

Benefits

See Issue

Possible drawbacks

Current default behavior left unchanged.

Applicable issues

Additional information

I seem to have a slightly different buf binary, as it produced a lot of changes in the generated code. I commited that as is, but as a seperate commit. I'm not sure how to solve that.

I was also unable to get the newly introduced field into the openapi spec. What am I missing here?

@netlify
Copy link

netlify bot commented Jun 26, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 8627595
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62d08e3f3b875b00084f6f3a

@antgamdia
Copy link
Contributor

Thanks for the contribution! We are currently in the middle of a release process (v2.4.6) and therefore we have a bunch of PRs pending review. We'll get to it as soon as possible! Anyway, it looks pretty good at a glance, thanks for the effort!

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Outstanding contribution: from a change in the proto file definition to the frontend code, besides changing the chart and other files. Well done!

Just for you to know, we are using this project for autogenerating the readme.md, this way, each param you add to the values, will get auto-documented. No need to execute it for this PR, we can do it later.

I only have a minor comment (adding a test case), but otherwise, LGTM.

@smerschjohann smerschjohann force-pushed the feat-4922 branch 2 times, most recently from 3591d33 to 8627595 Compare July 14, 2022 21:44
@smerschjohann
Copy link
Contributor Author

@antgamdia ok, I added the test and rebased the PR to the latest changes

@castelblanque
Copy link
Collaborator

Many thanks @smerschjohann !!
We really appreciate your contribution.

@castelblanque castelblanque merged commit bb87b2c into vmware-tanzu:main Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Namespace: add static labels to namespace
3 participants