-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Namespace: add static labels to namespace #4956
Conversation
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Thanks for the contribution! We are currently in the middle of a release process (v2.4.6) and therefore we have a bunch of PRs pending review. We'll get to it as soon as possible! Anyway, it looks pretty good at a glance, thanks for the effort! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Outstanding contribution: from a change in the proto file definition to the frontend code, besides changing the chart and other files. Well done!
Just for you to know, we are using this project for autogenerating the readme.md, this way, each param you add to the values, will get auto-documented. No need to execute it for this PR, we can do it later.
I only have a minor comment (adding a test case), but otherwise, LGTM.
3591d33
to
8627595
Compare
@antgamdia ok, I added the test and rebased the PR to the latest changes |
Many thanks @smerschjohann !! |
This change adds the ability to add labels to namespaces during creation. These labels can be configured in the
config.json
of the dashboard.Description of the change
createNamespaceLabels
to the Dashboard configurationBenefits
See Issue
Possible drawbacks
Current default behavior left unchanged.
Applicable issues
Additional information
I seem to have a slightly different
buf
binary, as it produced a lot of changes in the generated code. I commited that as is, but as a seperate commit. I'm not sure how to solve that.I was also unable to get the newly introduced field into the openapi spec. What am I missing here?