Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gosec to asset-syncer #4989

Merged
merged 2 commits into from
Jul 1, 2022
Merged

Add gosec to asset-syncer #4989

merged 2 commits into from
Jul 1, 2022

Conversation

antgamdia
Copy link
Contributor

@antgamdia antgamdia commented Jun 30, 2022

Description of the change

After reporting #4810 , I've added the linter just in the asset-syncer code .
The building is gonna fail now, but if we start fixing the issues, we will be, eventually, able to merge this PR.

Benefits

Prevent new gosec issues.

Possible drawbacks

N/A

Applicable issues

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Jun 30, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit c558bd4
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/62bdca5e2a5f810008023896

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@antgamdia antgamdia marked this pull request as ready for review June 30, 2022 16:16
@castelblanque
Copy link
Collaborator

Same question as here.
Code looks good to me.

@antgamdia antgamdia merged commit bb27163 into vmware-tanzu:main Jul 1, 2022
@antgamdia antgamdia deleted the gosec-1 branch July 1, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants