-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make CI build and use the e2e image #5083
Conversation
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Not sure that we want to build the E2E image every CI run. That adds a lot of time to the (already) slow CI pipeline. |
Well, this is a matter of considering the tradeoffs, I mean: on the one hand, there is the reproducibility, in that we are building whatever we later consume, so the repo is the single source of truth here. On the other, the time spent (in this case is just around 3 minutes). The whole discussion is here, but in short, we want to be able to know if a dependabot upgrade or an image update on the playwright runner is breaking the CI. Otherwise, we would only know it once we follow the release process and perform the regular updates. Perhaps we could improve it and just build the image for pushes to main if you want to save some time, but still, 3 minutes (given the order of magnitude we are handling, >20-30 min) is not that bad, IMHO. Anyway, happy to follow any alternative approach. |
+1 to building the image less times. Another option would be to have the task that builds it run only if e.g. integration's |
+1. In general, we should try to decrease CI times, but it makes sense for pushes to main, so we rely on what we're building is going to work later when releasing (do not wait to the release process to identify a dependency problem). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving as discussed in Slack.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Description of the change
This PR simply adds a new step in the CI so that the e2e runner image is built on each run.
Benefits
The CI will always use the latest integration image as it is being built on each CI run.
Possible drawbacks
If a dependency happens to break the e2e tests, the CI runs will also fail.
Applicable issues
Additional information
N/A