Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flux oci support 11: add integration test for Unable to use Flux OCI with Harbor robot accounts #5219 #5246

Merged
merged 10 commits into from
Aug 31, 2022

Conversation

gfichtenholt
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Aug 31, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit b1121ca
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/630f1e7940b1e6000a1eba92

@gfichtenholt gfichtenholt self-assigned this Aug 31, 2022
@gfichtenholt gfichtenholt linked an issue Aug 31, 2022 that may be closed by this pull request
Comment on lines +19 to 20
Make sure you see a message "Policy Updated" at the bottom of the screen when you grant these roles. If you see "Failed to add project roles" or some other error message,
create the service account with a different Name/ID
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just out of curiosity: is this why flux-plugin-test-sa-* is increasing the number?
Do you know the problem behind?

Copy link
Contributor Author

@gfichtenholt gfichtenholt Aug 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No technical reason. There are times when I have had multiple service accounts active for testing, so I increment the Name/ID to keep track of what's what. But I always make sure to clean it up and the end so there is a single service account for flux testing left
Screen Shot 2022-08-31 at 9 47 51 AM

Copy link
Collaborator

@castelblanque castelblanque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gfichtenholt
Copy link
Contributor Author

LGTM

Thank you

@gfichtenholt gfichtenholt merged commit d22a23b into vmware-tanzu:main Aug 31, 2022
@gfichtenholt gfichtenholt deleted the flux-oci-support-11 branch August 31, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Unable to use Flux OCI with Harbor robot accounts
3 participants