Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

E2E test to cover scenario of Kubeapps cluster not part of clusters list #5573

Merged
merged 14 commits into from
Nov 3, 2022
Merged

E2E test to cover scenario of Kubeapps cluster not part of clusters list #5573

merged 14 commits into from
Nov 3, 2022

Conversation

castelblanque
Copy link
Collaborator

Description of the change

This PR adds an E2E test in CI to avoid regression on #5566 and hence to avoid that #4564 happens again.

Benefits

Kubeapps is usable even if Kubeapps cluster is not among the clusters configured.

Possible drawbacks

N/A

Applicable issues

Rafa Castelblanque added 4 commits October 25, 2022 15:30
Add explicit token for Kubeapps cluster reference
9408a8e 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Add E2E test for no kubeapps cluster
b8c698a 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Try to fix Kubeapps CI install
553f255 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Merge branch 'main' into 4564-ci-test
6ac38f5 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@netlify
Copy link

netlify bot commented Oct 26, 2022 •
edited
Loading

✅ Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 293a55c
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6363e1dbc6fe610009b48b60

Rafa Castelblanque added 5 commits October 26, 2022 16:50
Add missing slashes
43b6caa 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Trying to workaround the multicluster fixed flags
2492831 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Fix E2E runner call
ef2dc09 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Add wait for Kubeapps deploy
5de89a2 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Fine tuning test
3cd909e 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@castelblanque castelblanque marked this pull request as ready for review October 27, 2022 09:24
Move E2E to last one to be run
9a641eb 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
antgamdia
antgamdia approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great way to avoid regressions like the one you mentioned
+1 once the merge conflicts are solved.

Rafa Castelblanque added 4 commits November 3, 2022 11:55
Merge branch 'main' into 4564-ci-test
844114f 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Removing unnecessary values on upgrade
fb3fed7 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Adding missing PostgreSQL password
f1728d2 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Trying new setup for CircleCI and GHA
293a55c 
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
@castelblanque castelblanque merged commit 317934a into main Nov 3, 2022
@castelblanque castelblanque deleted the 4564-ci-test branch November 3, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antgamdia antgamdia antgamdia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add CI coverage for environment where kubeappsCluster is empty.
2 participants
@castelblanque @antgamdia