Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust concurrency in gha workflow #5618

Merged

Conversation

beni0888
Copy link
Collaborator

@beni0888 beni0888 commented Nov 8, 2022

Description of the change

With these changes we achieve the following:

  • Do not trigger the Kubeapps Main Pipeline workflow for every push, only for pushes to the master branch.
  • Use a different concurrency group for the Release Pipeline, so a later workflow triggered from a push to the main branch won't cancel the release pipeline.
  • Do not trigger the Kubeapps Main Pipeline workflow on tags creation. We trigger the release pipeline for this event and don't want a second pipeline running on the same version of the code, that could interfere with the former (eg. canceling the release pipeline because they both run in the same concurrency group).

Benefits

  • Less number of pipelines triggered, and the triggered ones are more meaningful.
  • A more resilient release flow.

Possible drawbacks

  • The main pipeline isn't triggered until a PR is triggered so the feedback loop could be larger.

Applicable issues

Additional information

N/A

Jesús Benito Calzada added 2 commits November 8, 2022 11:48
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@beni0888 beni0888 self-assigned this Nov 8, 2022
@netlify
Copy link

netlify bot commented Nov 8, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 587d148
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/636a409dd88a1a0009bc6213

@beni0888 beni0888 added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 8, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Nov 8, 2022
@beni0888 beni0888 marked this pull request as ready for review November 8, 2022 11:43
Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@beni0888 beni0888 merged commit 6d6424c into vmware-tanzu:main Nov 8, 2022
@beni0888 beni0888 deleted the adjust-concurrency-in-gha-workflow branch November 8, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants