Remove js-yaml dependency #5627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
absoludity
approved these changes
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
After the revamping of the basic forms view, we left untouched the tech debt pointed in #5435: we were using two different libraries for the same purpose - dealing with YAML files.
This PR is removing
js-yamlin favor ofyaml, which offers a node representation of the parsed AST and makes, therefore, possible, dealing with comments in the file.Benefits
A single library for dealing with yaml files.
Possible drawbacks
I've tried to preserve the same behavior, but, for instance, the quotation policies in
js-yamldiffer from the ones inyaml. Not a big deal, though.Applicable issues
js-yamlandYAMLlibraries are still required #5435Additional information
N/A