Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix srp_report GHA's job #5647

Merged
merged 3 commits into from
Nov 16, 2022
Merged

Conversation

beni0888
Copy link
Collaborator

Signed-off-by: Jesús Benito Calzada bjesus@vmware.com

Description of the change

It seems that there is a bug in the current version of the GHA's report_srp job we've just merged, and for some reason, the SRP_CLI_VERSION is not being properly passed in the call to the srp-source-provenance action.

Benefits

Fix the bug in the GHA's report_srp job, so it works as expected.

Possible drawbacks

None

Applicable issues

Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 32a5531
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/637501a018970600088be9a5

@beni0888 beni0888 self-assigned this Nov 16, 2022
@beni0888 beni0888 added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 16, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Nov 16, 2022
@beni0888 beni0888 marked this pull request as ready for review November 16, 2022 15:22
Jesús Benito Calzada added 2 commits November 16, 2022 16:27
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
Copy link
Collaborator

@ppbaena ppbaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @beni0888!

@beni0888 beni0888 merged commit aa0195c into vmware-tanzu:main Nov 16, 2022
@beni0888 beni0888 deleted the fix-gha-srp-report branch November 16, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants