Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated parameter in the call to srp tool #5657

Merged
merged 2 commits into from
Nov 17, 2022

Conversation

beni0888
Copy link
Collaborator

Signed-off-by: Jesús Benito Calzada bjesus@vmware.com

Description of the change

Even though the report_srp job of the GHA's pipeline is working properly, it's showing a warning due to the use of a deprecated argument in the call to the srp tool. Here we replace that argument by the new recommended one.

Benefits

We get rid of a deprecated argument in the call to the srp CLI tool and remove the risk of a future failure when updating to a new version that no longer supports the deprecated argument.

Possible drawbacks

None

Applicable issues

Additional information

Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@netlify
Copy link

netlify bot commented Nov 17, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 1cfdfa8
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6375dc0071bfdc00097e93ad

@beni0888 beni0888 marked this pull request as ready for review November 17, 2022 06:58
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@beni0888 beni0888 self-assigned this Nov 17, 2022
@beni0888 beni0888 added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 17, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Nov 17, 2022
@beni0888 beni0888 merged commit 5d8390b into vmware-tanzu:main Nov 17, 2022
@beni0888 beni0888 deleted the update-gha-srp-report branch November 17, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants