Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce #5805 and fix. #5826

Merged
merged 3 commits into from
Jan 10, 2023

Conversation

absoludity
Copy link
Contributor

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Ensures that deployment form can still display even if the schemaEditor feature flag is not set.

Benefits

Fixes the immediate error shown for #5805, though I'm not convinced it'll be the only error (it's still not clear why the configuration options would not be set).

Possible drawbacks

Applicable issues

Additional information

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Dec 22, 2022

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 451936e
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63bd08a95e3f9a00086e23c7

Signed-off-by: Michael Nelson <minelson@vmware.com>
@stale
Copy link

stale bot commented Jan 7, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Automatic label to stale issues due inactivity to be closed if no further action label Jan 7, 2023
@absoludity absoludity removed the stale Automatic label to stale issues due inactivity to be closed if no further action label Jan 8, 2023
@absoludity absoludity merged commit 32292ff into vmware-tanzu:main Jan 10, 2023
@absoludity absoludity deleted the 5805-feature-not-present branch January 10, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants