Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to a custom default values if exactly one provided. #5856

Merged
merged 4 commits into from
Jan 13, 2023

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Jan 11, 2023

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

This change uses the new support for custom default values files so that:

  • if a single custom default values file is found in the chart, it is presented to the user so that authors can control the default values presented to users.

Note that, since it is just an overlay over the charts values.yaml, it can be used both to present a simpler selection of options to users, or to present a different set of default values.

Benefits

Fulfills use-case 1 of #5692 .

Possible drawbacks

Applicable issues

Additional information

Using the custom default values in the simplechart, before the user makes any changes, they are presented with those values (only):

5692-simplechart-no-changes

Any changes made are diffed against the custom default:
5692-simplechart-smallchange

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Jan 11, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 30d1c1f
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63bf6e9ded28c30009d15766

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@@ -104,7 +104,7 @@ installChartMuseum() {
--set persistence.enabled=true \
--set env.secret.BASIC_AUTH_USER=$CHARTMUSEUM_USER \
--set env.secret.BASIC_AUTH_PASS=$CHARTMUSEUM_PWD
info "Waiting for ChartMuseum to be ready..."
echo "Waiting for ChartMuseum to be ready..."
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using echo like the rest of the script, so the script itself can be run without dependencies. Useful for setting up.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity marked this pull request as ready for review January 12, 2023 02:28
@absoludity absoludity merged commit 9f92766 into main Jan 13, 2023
@absoludity absoludity deleted the 5692-dashboard branch January 13, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants