Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace stub request with real (non-authed) dockerhub request. #6297

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

absoludity
Copy link
Contributor

Description of the change

Adds implementation of send_repositories for the dockerhub implementation, replacing the stub.

Benefits

Actual results (see below).

Applicable issues

Additional information

Logs for request show two separate requests to hub.docker:

RUST_LOG=debug cargo run
    Finished dev [unoptimized + debuginfo] target(s) in 0.52s
     Running `target/debug/oci-catalog`
[2023-06-13T01:54:29Z INFO  oci_catalog] listening for gRPC requests at 0.0.0.0:50001
[2023-06-13T01:54:33Z DEBUG oci_catalog::providers::dockerhub] requesting: https://hub.docker.com/v2/namespaces/bitnamicharts/repositories/?page_size=100&ordering=name&content_types=helm
[2023-06-13T01:54:33Z DEBUG reqwest::connect] starting new connection: https://hub.docker.com/
[2023-06-13T01:54:35Z DEBUG oci_catalog::providers::dockerhub] requesting: https://hub.docker.com/v2/namespaces/bitnamicharts/repositories/?content_types=helm&ordering=name&page=2&page_size=100

Request shows grpc streaming the full result.

grpcurl -proto ./proto/ocicatalog.proto -d '{"registry": "registry-1.docker.io", "namespace": "bitnamicharts", "content_types":["helm"]}' -plaintext "0.0.0.0:50001" ocicatalog.OCICatalog.ListRepositoriesForRegistry
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "airflow"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "apache"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "apisix"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "appsmith"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "argo-cd"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "argo-workflows"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "aspnet-core"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "cassandra"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "cert-manager"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "clickhouse"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "common"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "concourse"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "consul"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "contour"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "contour-operator"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "discourse"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "dokuwiki"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "drupal"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "ejbca"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "elasticsearch"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "etcd"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "external-dns"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "flink"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "fluent-bit"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "fluentd"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "flux"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "ghost"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "gitea"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "grafana"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "grafana-loki"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "grafana-mimir"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "grafana-operator"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "grafana-tempo"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "haproxy"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "harbor"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "influxdb"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "jaeger"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "jasperreports"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "jenkins"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "joomla"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "jupyterhub"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kafka"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "keycloak"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kiam"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kibana"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kong"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kubeapps"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kube-prometheus"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kubernetes-event-exporter"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "kube-state-metrics"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "logstash"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "magento"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mariadb"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mariadb-galera"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mastodon"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "matomo"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mediawiki"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "memcached"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "metallb"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "metrics-server"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "minio"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mongodb"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mongodb-sharded"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "moodle"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "multus-cni"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mxnet"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "mysql"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "nats"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "nginx"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "nginx-ingress-controller"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "node-exporter"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "oauth2-proxy"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "odoo"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "opencart"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "osclass"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "parse"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "phpbb"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "phpmyadmin"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "pinniped"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "postgresql"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "postgresql-ha"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "prestashop"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "prometheus"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "pytorch"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "rabbitmq"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "rabbitmq-cluster-operator"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "redis"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "redis-cluster"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "redmine"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "schema-registry"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "sealed-secrets"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "solr"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "sonarqube"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "spark"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "spring-cloud-dataflow"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "suitecrm"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "supabase"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "tensorflow-resnet"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "thanos"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "tomcat"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "vault"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "wavefront"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "wavefront-hpa-adapter"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "wavefront-prometheus-storage-adapter"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "whereabouts"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "wildfly"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "wordpress"
}
{
  "registry": "registry-1.docker.io",
  "namespace": "bitnamicharts",
  "name": "zookeeper"
}

@netlify
Copy link

netlify bot commented Jun 13, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 93069cc
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/6487ccdae1065b000802bf68

@absoludity absoludity merged commit dd3f7ef into main Jun 14, 2023
@absoludity absoludity deleted the 6263-oci-catalog-4-dockerhub1 branch June 14, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants