Ensure token auth can be configured while oauthLoginURI is defined. #6557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
absoludity
commented
Aug 3, 2023
| @@ -39,6 +38,7 @@ export const initialState = { | |||
| kubeappsNamespace: "kubeapps", | |||
| helmGlobalNamespace: "kubeapps-repos-global", | |||
| carvelGlobalNamespace: "kapp-controller-packaging-global", | |||
| oauthLoginURI: "/oauth/login", | |||
There was a problem hiding this comment.
I set this in our default state so to trigger the failures in the tests that should have caught it. Lesson: always use default settings in tests that match your prod default settings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When switching from a container to a component with hooks, I missed that the prop was passed from the container as:
but with the component the oauthLoginURI was always defined.
Benefits
Can configure token auth again
Possible drawbacks
Applicable issues
Additional information