-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use OCI catalog service when available for OCI validation #6635
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -166,6 +166,8 @@ spec: | |||
secretKeyRef: | |||
key: postgres-password | |||
name: {{ include "kubeapps.postgresql.secretName" . }} | |||
- name: OCI_CATALOG_URL | |||
value: {{ printf ":%d" (int .Values.ociCatalog.containerPorts.http) | quote }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't checked, but I assume containerPorts.http
is actually pointing to the grpc endpoint, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is only one endpoint. Perhaps we should name it grpc instead... (I mean, grpc is http2, but I think the container template I used to create the ocicatalog helm section used http, grpc might be more descriptive).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Much more descriptive this way
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
3fe36c0
to
3bb4c26
Compare
✅ Deploy Preview for kubeapps-dev canceled.
|
Signed-off-by: Michael Nelson <minelson@vmware.com>
Description of the change
Follows on from #6620, uses the grpc Client to check if we can find repos for an OCI registry. While there I improved a couple of other things regarding the validation:
I've added a basic test double grpc service for the OCI catalog to use here in tests, and will undoubtedly improve this test double when adding the actual sync functionality to use the OCI catalog service next.
Benefits
OCI Catalog service can be used to check an OCI Registry, without impacting current behaviour.
Possible drawbacks
None that I'm aware of.
Applicable issues
Additional information
I'll test IRL locally and update here:
Logs showing the fallback when the OCI catalog is not running:
and verified I can add the Bitnami catalog using the OCI
https://registry-1.docker.io/bitnamicharts
. That is, it passes validation and gets added. It doesn't yet sync - that'll be the next PR.