Update vmware-tanzu/carvel-vendir to carvel.dev/vendir
#7515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
force-pushed
the
updateVendir
branch
from
37e5f60
to
b361936
Compare
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
force-pushed
the
updateVendir
branch
from
72d561b
to
3b72a87
Compare
antgamdia
commented
Feb 23, 2024
Comment on lines
+11
to
+13
| // This is a temporary function to convert from the new vendir version to the old | ||
| // vendir version. This can be removed once the new vendir version is released. | ||
| // More details at https://github.com/vmware-tanzu/kubeapps/pull/7515 |
There was a problem hiding this comment.
This PR will be partially reverted once kapp-ctrl also updates its vendir dep.
|
I've opened a PR in kapp-ctrl to speed up their transition to the new vendir version: carvel-dev/kapp-controller#1497 |
antgamdia
added a commit
to antgamdia/kubeapps
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
antgamdia
added a commit
to antgamdia/kubeapps
that referenced
this pull request
Mar 25, 2024
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When upgrading deps with dependabot, we are getting errors like:
so this MR is to use
carvel.dev/vendirinstead.Benefits
No more errors when running dependabot.
Possible drawbacks
N/A
Applicable issues
N/A
Additional information
N/A