Add unit test for core/crypto and a little change in the empty []byte return value. #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DecryptBytesAge function returns an error, it returns
nil instead of []byte{}.
Signed-off-by: Yiğithan Karabulut <yigithannkarabulutt@gmail.com>
v0lkan
reviewed
Jun 28, 2024
| @@ -78,14 +78,14 @@ func DecryptBytesAge(data []byte) ([]byte, error) { | |||
|
|
|||
| identity, err := age.ParseX25519Identity(privateKey) | |||
| if err != nil { | |||
| return []byte{}, errors.Join( | |||
| return nil, errors.Join( | |||
|
Looking good. Thanks for your contributions @yigithankarabulut . We badly need to increase test coverage, and I do understand writing test is not the funniest thing to do. So we truly appreciate your efforts 🙏 . -- Landing this one. I’ll run all unit and integration tests on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit testing to core/crypto/decrypt_test.go
Description
Test coverage increased from %11.8 to %85.5 in core/crypto.
Updated the DecryptBytesAge() function to return nil instead of []bytes{} if it returns an error.
Changes
List the major changes you have made in bullet points:
Add Test for core/crypto/decrypt_test.go #891
Test Policy Compliance
Code Quality
to understand.
Documentation
Additional Comments
Include any additional comments or context about the PR here.
Checklist
Before you submit this PR, please make sure:
especially the test policy.
under the project's license.
By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.
Thank you for your contribution to VMware Secrets Manager
🐢⚡️!