Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(VSecM Helm Charts): remove ability to not use SCM #1064

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

v0lkan
Copy link
Contributor

@v0lkan v0lkan commented Jul 9, 2024

Remove Option to Opt Out From SPIRE Controller Manager

Description

This PR removes the useClusterSpiffeIDs and useSpireControllerManager options from the helm charts.

SPIRE helm charts use SPIRE Controller Manager, and disabling it is nontrivial. Also, ClusterSPIFFEIDs are the best way to manage SPIFFEIDs in a Kubernetes cluster. — If we find a use case where these options are necessary, or if there is a need from the community, we can modify the code to let SPIRE install without SPIRE Controller Manager and bring those flags back.

Test Policy Compliance

  • I have added or updated unit tests for my changes.
  • I have included integration tests where applicable.
  • All new and existing tests pass successfully.

Code Quality

  • I have followed the coding standards for this project.
  • I have performed a self-review of my code.
  • My code is well-commented, particularly in areas that may be difficult
    to understand.

Documentation

  • I have made corresponding changes to the documentation (if applicable).
  • I have updated any relevant READMEs or wiki pages.

Additional Comments

Include any additional comments or context about the PR here.

Checklist

Before you submit this PR, please make sure:

  • You have read the contributing guidelines and
    especially the test policy.
  • You have thoroughly tested your changes.
  • You have followed all the contributing guidelines for this project.
  • You understand and agree that your contributions will be publicly available
    under the project's license.

By submitting this pull request, you confirm that my contribution is made under
the terms of the project's license and that you have the authority to grant
these rights.


Thank you for your contribution to VMware Secrets Manager
🐢⚡️!

This PR removes the useClusterSpiffeIDs and useSpireControllerManager
options from the helm charts.

SPIRE helm charts use SPIRE Controller Manager, and disabling it
is nontrivial. Also, ClusterSPIFFEIDs are the best way to manage SPIFFEIDs
in a Kubernetes cluster. — If we find a use case where these options are
necessary, or if there is a need from the community, we can modify the
code to let SPIRE install without SPIRE Controller Manager and bring those
flags back.

Signed-off-by: Volkan Özçelik <volkan.ozcelik@broadcom.com>
@v0lkan v0lkan self-assigned this Jul 9, 2024
@v0lkan v0lkan requested a review from BulldromeQ as a code owner July 9, 2024 05:25
@v0lkan v0lkan merged commit a4e31f7 into main Jul 9, 2024
@v0lkan v0lkan deleted the ovolkan/scm branch July 9, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant