Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ServiceBinding controller should not use servicebinding.io/controller: "true" for non-provisioned service rbac #238

Closed
Samze opened this issue Jun 7, 2022 · 1 comment · Fixed by #239
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Samze
Copy link
Contributor

Samze commented Jun 7, 2022

Bug description

The ServiceBinding controller currently relies on the spec ClusterRole label servicebinding.io/controller: "true" to aggregate non-provisionedservice RBAC to the controller manager. See deployed config here.

The means any system that also aggregates on servicebinding.io/controller: "true" will pick up the internal RBAC for this controller. This also includes write permissions such as create/delete/update.

Expected behavior

That servicebinding.io/controller: "true" is only used for ProvisionedService types and should only contain get/list/watch.

@Samze Samze added the bug Something isn't working label Jun 7, 2022
@atmandhol atmandhol added this to the 0.7.2 milestone Jun 8, 2022
@rashedkvm
Copy link
Member

rashedkvm commented Jun 8, 2022

Creating a new cluster role with label selector servicebinding.io/controller: "true" for get, list, and watch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants