Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New ClusterRole service-binding-provisioned-service, updated label selectors #239

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

rashedkvm
Copy link
Member

New ClusterRole service-binding-provisioned-service, updated existing roles

Signed-off-by: Rashed Kamal krashed@vmware.com

Pull request

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #238

Describe testing done for PR

Additional information or special notes for your reviewer

…sting roles

Signed-off-by: Rashed Kamal <krashed@vmware.com>
@vmwclabot vmwclabot added the cla-not-required CLA not required label Jun 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #239 (4f2c608) into main (7f1139f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   93.02%   93.02%           
=======================================
  Files          16       16           
  Lines         774      774           
=======================================
  Hits          720      720           
  Misses         42       42           
  Partials       12       12           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f1139f...4f2c608. Read the comment docs.

@rashedkvm rashedkvm requested a review from scothis June 9, 2022 03:32
config/200-clusterrole.yaml Show resolved Hide resolved
config/200-clusterrole.yaml Outdated Show resolved Hide resolved
config/201-clusterrolebinding.yaml Outdated Show resolved Hide resolved
Signed-off-by: Rashed Kamal <krashed@vmware.com>
@rashedkvm rashedkvm marked this pull request as ready for review June 9, 2022 14:10
@rashedkvm rashedkvm merged commit 0310eac into vmware-tanzu:main Jun 9, 2022
@rashedkvm rashedkvm deleted the update-cluster-role branch June 9, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ServiceBinding controller should not use servicebinding.io/controller: "true" for non-provisioned service rbac
4 participants