Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment variables added multiple times #67

Closed
arturdzm opened this issue Sep 24, 2020 · 1 comment · Fixed by #77
Closed

Environment variables added multiple times #67

arturdzm opened this issue Sep 24, 2020 · 1 comment · Fixed by #77

Comments

@arturdzm
Copy link

If someone or something removes internal.service.binding/projection-.... annotation from application resource (eg Deployment) environment variables are aded more then once in infinite reconcile loop.

@scothis
Copy link
Contributor

scothis commented Sep 25, 2020

Yea, those fields are essential to know what values were contributed vs preexisting on the resource before it's injected. Since we have a mutation webhook already intercepting all mutations on those resources, we can prevent any authority that isn't the service binding controller from removing that field.

I'm curious if we could mildly abuse the finalizers to encode this data there? A controlling owner would never expect to control the finalizers unlike annotations which it may try to control.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants