Cleanup injected values based on annotations and ServiceBindingProjection #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion This provides robustness against a controller that attempts to remove the `internal.service.binding/projection-*` annotation, as the mutating webhook will detect the change and reapply the annotation. By cleaning up based on both source values, we can be more certain that conflicts can be avoided. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #77 +/- ##
=======================================
Coverage 91.40% 91.40%
=======================================
Files 18 18
Lines 570 570
=======================================
Hits 521 521
Misses 28 28
Partials 21 21
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides robustness against a controller that attempts to remove
the
internal.service.binding/projection-*annotation, as the mutatingwebhook will detect the change and reapply the annotation.
By cleaning up based on both source values, we can be more certain that
conflicts can be avoided.
Resolves #67