Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Custom Projection support #123

Merged
merged 1 commit into from
Mar 22, 2021

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Mar 22, 2021

The Custom Projection extension was dropped from the Service Binding
spec. We no longer need to maintain it.

The ServiceBindingProjection resource is still used to manage the
binding, but it has moved into the internal.bindings.labs.vmware.com API
group and is now an implementation detail rather than a supported
interface.

Refs servicebinding/spec#143
Resolves #118

@vmwclabot vmwclabot added the cla-not-required CLA not required label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #123 (043ea8b) into main (c610b7e) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   91.50%   92.20%   +0.69%     
==========================================
  Files          18       17       -1     
  Lines         577      539      -38     
==========================================
- Hits          528      497      -31     
+ Misses         28       24       -4     
+ Partials       21       18       -3     
Impacted Files Coverage Δ
pkg/apis/labsinternal/v1alpha1/register.go 100.00% <ø> (ø)
...nternal/v1alpha1/servicebindingprojection_types.go 100.00% <ø> (ø)
...is/servicebinding/v1alpha2/servicebinding_types.go 100.00% <ø> (ø)
pkg/reconciler/servicebinding/controller.go 100.00% <ø> (ø)
...nal/v1alpha1/servicebindingprojection_lifecycle.go 100.00% <100.00%> (ø)
...ervicebinding/v1alpha2/servicebinding_lifecycle.go 100.00% <100.00%> (ø)
...rvicebinding/resources/servicebindingprojection.go 100.00% <100.00%> (ø)
pkg/reconciler/servicebinding/servicebinding.go 75.92% <100.00%> (ø)
.../reconciler/servicebindingprojection/controller.go 57.14% <100.00%> (-5.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c610b7e...043ea8b. Read the comment docs.

The Custom Projection extension was dropped from the Service Binding
spec. We no longer need to maintain it.

The ServiceBindingProjection resource is still used to manage the
binding, but it has moved into the internal.bindings.labs.vmware.com API
group and is now an implementation detail rather than a supported
interface.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis merged commit b3c7532 into vmware-tanzu:main Mar 22, 2021
@scothis scothis deleted the drop-custom-projection branch March 22, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for custom projection
2 participants