Drop specifying containers by index #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the container index is not defined as semantically meaningful, it is inherently unstable to make security related decisions based on. Use the container name instead to restrict access to specific containers. This capability was removed from the spec. Refs: servicebinding/spec#171 Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #158 +/- ##
==========================================
- Coverage 94.51% 94.46% -0.05%
==========================================
Files 16 16
Lines 583 578 -5
==========================================
- Hits 551 546 -5
Misses 21 21
Partials 11 11
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the container index is not defined as semantically meaningful, it
is inherently unstable to make security related decisions based on. Use
the container name instead to restrict access to specific containers.
This capability was removed from the spec.
Refs: servicebinding/spec#171
Signed-off-by: Scott Andrews andrewssc@vmware.com