Switch from Knative conditions to metav1.Condition

[scothis]

metav1.Condition requires a Reason for all conditions. We are now in
sync with the spec defined ServiceBinding resource shape.

Signed-off-by: Scott Andrews andrewssc@vmware.com

[codecov]

Codecov Report

Merging #159 (0371926) into main (fdccc48) will increase coverage by 0.15%.
The diff coverage is 98.07%.

❗ Current head 0371926 differs from pull request most recent head 1483422. Consider uploading reports for the commit 1483422 to get more accurate results

@@            Coverage Diff             @@
##             main     #159      +/-   ##
==========================================
+ Coverage   94.46%   94.61%   +0.15%     
==========================================
  Files          16       16              
  Lines         578      613      +35     
==========================================
+ Hits          546      580      +34     
- Misses         21       22       +1     
  Partials       11       11              

Impacted Files	Coverage Δ
...is/servicebinding/v1alpha2/servicebinding_types.go	100.00% <ø> (ø)
...ervicebinding/v1alpha2/servicebinding_lifecycle.go	98.03% <97.91%> (-1.97%)	⬇️
pkg/reconciler/servicebinding/controller.go	100.00% <100.00%> (ø)
pkg/reconciler/servicebinding/servicebinding.go	79.41% <100.00%> (+0.30%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdccc48...1483422. Read the comment docs.

[shashwathi]

What is the need for passing time into setting status functions? Potentially, the function could add the current time when it's called. In the unit test, we could ignore LastTransitionTime field in comparison

[scothis]

What is the need for passing time into setting status functions? Potentially, the function could add the current time when it's called. In the unit test, we could ignore LastTransitionTime field in comparison

Testability. Since time is inherently non-deterministic, we can make these functions deterministic by injecting the timestamp. Before this change, the tests ignored the timestamps, but since we're now setting the timestamps, and when the timestamp gets updated is important, we can't just ignore the value.