Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V1alpha3 conversion #173

Merged
merged 5 commits into from
Sep 10, 2021
Merged

V1alpha3 conversion #173

merged 5 commits into from
Sep 10, 2021

Conversation

rashedkvm
Copy link
Member

@rashedkvm rashedkvm commented Sep 9, 2021

V1alpha3 conversion.

Resolves #171

@vmwclabot vmwclabot added the cla-not-required CLA not required label Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #173 (cfea9b9) into main (c893a9f) will not change coverage.
The diff coverage is 100.00%.

❗ Current head cfea9b9 differs from pull request most recent head f8553b3. Consider uploading reports for the commit f8553b3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #173   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files          16       16           
  Lines         641      641           
=======================================
  Hits          605      605           
  Misses         25       25           
  Partials       11       11           
Impacted Files Coverage Δ
pkg/apis/servicebinding/v1alpha3/register.go 100.00% <ø> (ø)
...ervicebinding/v1alpha3/servicebinding_lifecycle.go 94.93% <ø> (ø)
...is/servicebinding/v1alpha3/servicebinding_types.go 100.00% <ø> (ø)
pkg/reconciler/servicebinding/controller.go 100.00% <100.00%> (ø)
...rvicebinding/resources/servicebindingprojection.go 100.00% <100.00%> (ø)
pkg/reconciler/servicebinding/servicebinding.go 79.41% <100.00%> (ø)
pkg/resolver/serviceable_resolver.go 92.59% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c893a9f...f8553b3. Read the comment docs.

@@ -9,6 +9,9 @@ metadata:
bindings.labs.vmware.com/release: devel
aggregationRule:
clusterRoleSelectors:
- matchLabels:
servicebinding.io/controller: "true"
# legacy support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@scothis scothis merged commit 1786b9d into vmware-tanzu:main Sep 10, 2021
@rashedkvm rashedkvm deleted the v1alpha3 branch September 10, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename service.binding/v1alpha2 to servicebinding.io/v1alpha3
3 participants