Test for clean redeploys with kapp #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #208 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 16 16
Lines 637 637
=======================================
Hits 601 601
Misses 25 25
Partials 11 11 Continue to review full report at Codecov.
|
scothis
force-pushed
the
kapp-clean-deploy
branch
3 times, most recently
from
0241248
to
ea6137c
Compare
|
I don't know why the PR actions are not running, the push actions ran here |
A kapp deploy will attempt to make the resources on the api server match the resources defined locally. Because the manager will modify the resources we create at runtime, we should respect those mutations and avoid overwriting them. This is typically done with rebase rules in the kapp config resource. During the acceptance tests, we set the kapp-controller sync period for the package to 1 minute. If we see multiple changeset, the config is not stable. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
force-pushed
the
kapp-clean-deploy
branch
from
ea6137c
to
ae2e3e8
Compare
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
force-pushed
the
kapp-clean-deploy
branch
from
7e33c01
to
26649a6
Compare
rashedkvm
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A kapp deploy will attempt to make the resources on the api server match
the resources defined locally. Because the manager will modify the
resources we create at runtime, we should respect those mutations and
avoid overwriting them. This is typically done with rebase rules in the
kapp config resource.
During the acceptance tests, we set the kapp-controller sync period for
the package to 1 minute. If we see multiple changeset, the config is not
stable.
Signed-off-by: Scott Andrews andrewssc@vmware.com