Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated log time stamp format to match RFC-3339 #224

Merged
merged 2 commits into from
Mar 3, 2022

Conversation

rashedkvm
Copy link
Member

Signed-off-by: Rashed Kamal krashed@vmware.com

Pull request

What this PR does / why we need it

Which issue(s) this PR fixes

  • Enabled config-logging
  • Sets "timeEncoder": "rfc3339nano"

Fixes #223

Describe testing done for PR

Log snippet after config update

{"level":"info","ts":"2022-03-02T18:19:36.1942387Z","logger":"webhook.ValidationWebhook","caller":"controller/controller.go:538","msg":"Reconcile succeeded","knative.dev/traceid":"a64b6f1e-d543-43bc-abcb-e5b5955b3f11","knative.dev/key":"validation.webhook.bindings.labs.vmware.com","duration":0.0106878}
{"level":"info","ts":"2022-03-02T18:19:36.1963836Z","logger":"webhook.DefaultingWebhook","caller":"controller/controller.go:538","msg":"Reconcile succeeded","knative.dev/traceid":"db874d27-8b62-472f-a7f6-41618e14099f","knative.dev/key":"defaulting.webhook.bindings.labs.vmware.com","duration":0.0122473}
{"level":"info","ts":"2022-03-02T18:19:36.2089394Z","logger":"webhook.ValidationWebhook","caller":"validation/reconcile_config.go:168","msg":"Updating webhook","knative.dev/traceid":"22cc673f-89d0-4f5d-8936-e77ebb1c45aa","knative.dev/key":"validation.webhook.bindings.labs.vmware.com"}
{"level":"info","ts":"2022-03-02T18:19:36.2095734Z","logger":"webhook.DefaultingWebhook","caller":"defaulting/defaulting.go:205","msg":"Updating webhook","knative.dev/traceid":"1c4c548a-a3b2-4e3e-a99f-cc667d919368","knative.dev/key":"defaulting.webhook.bindings.labs.vmware.com"}
{"level":"info","ts":"2022-03-02T18:19:36.2149879Z","logger":"webhook.DefaultingWebhook","caller":"controller/controller.go:538","msg":"Reconcile succeeded","knative.dev/traceid":"1c4c548a-a3b2-4e3e-a99f-cc667d919368","knative.dev/key":"defaulting.webhook.bindings.labs.vmware.com","duration":0.0098519}
{"level":"info","ts":"2022-03-02T18:19:36.2164648Z","logger":"webhook.ValidationWebhook","caller":"controller/controller.go:538","msg":"Reconcile succeeded","knative.dev/traceid":"22cc673f-89d0-4f5d-8936-e77ebb1c45aa","knative.dev/key":"validation.webhook.bindings.labs.vmware.com","duration":0.0119458}

Additional information or special notes for your reviewer

@vmwclabot vmwclabot added the cla-not-required CLA not required label Mar 2, 2022
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #224 (03e739b) into main (7d5da15) will not change coverage.
The diff coverage is n/a.

❗ Current head 03e739b differs from pull request most recent head d851506. Consider uploading reports for the commit d851506 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          16       16           
  Lines         637      637           
=======================================
  Hits          601      601           
  Misses         25       25           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5da15...d851506. Read the comment docs.

@rashedkvm rashedkvm requested a review from scothis March 2, 2022 18:40
config/config-logging.yaml Outdated Show resolved Hide resolved
config/config-logging.yaml Outdated Show resolved Hide resolved
config/config-logging.yaml Outdated Show resolved Hide resolved
@rashedkvm rashedkvm force-pushed the logging-update branch 2 times, most recently from a32f719 to c2d4e4f Compare March 2, 2022 20:59
Signed-off-by: Rashed Kamal <krashed@vmware.com>
config/config-logging.yaml Outdated Show resolved Hide resolved
Signed-off-by: Rashed Kamal <krashed@vmware.com>
@rashedkvm rashedkvm merged commit 74031ea into vmware-tanzu:main Mar 3, 2022
@rashedkvm rashedkvm deleted the logging-update branch March 3, 2022 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Log format timestamp
3 participants