Support servicebinding.io/v1beta1 #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The API is compatible with v1alpha3 and does not require a conversion webhook. The controller and webhook still operate against v1alpha3, and can be upgraded at some point in the future. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
|
Keeping as a draft until the Service Binding spec formerly releases v1beta1. |
Signed-off-by: Scott Andrews <andrewssc@vmware.com>
scothis
commented
Mar 3, 2022
| @@ -212,3 +212,192 @@ spec: | |||
| storage: true | |||
| subresources: | |||
| status: {} | |||
| - additionalPrinterColumns: | |||
There was a problem hiding this comment.
from https://github.com/servicebinding/spec/blob/v1.0.0/servicebinding.io_servicebindings.yaml#L19-L207
Only change is that we're keeping v1alpha3 as the stored version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API is compatible with v1alpha3 and does not require a conversion
webhook. The controller and webhook still operate against v1alpha3, and
can be upgraded at some point in the future.
Signed-off-by: Scott Andrews andrewssc@vmware.com