Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Preserve backwards compatibility, for now" #61

Merged
merged 2 commits into from
Sep 22, 2020

Conversation

scothis
Copy link
Contributor

@scothis scothis commented Sep 22, 2020

This reverts commit cf501e7.

Resolves #51

This reverts commit cf501e7.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@vmwclabot vmwclabot added the cla-not-required CLA not required label Sep 22, 2020
@codecov
Copy link

codecov bot commented Sep 22, 2020

Codecov Report

Merging #61 into main will decrease coverage by 0.95%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
- Coverage   92.01%   91.05%   -0.96%     
==========================================
  Files          18       18              
  Lines         651      548     -103     
==========================================
- Hits          599      499     -100     
+ Misses         31       28       -3     
  Partials       21       21              
Impacted Files Coverage Δ
...nal/v1alpha2/servicebindingprojection_lifecycle.go 100.00% <100.00%> (ø)
...econciler/provisionedservice/provisionedservice.go 75.00% <0.00%> (-5.00%) ⬇️
pkg/reconciler/servicebinding/servicebinding.go 75.23% <0.00%> (-2.16%) ⬇️
pkg/resolver/serviceable_resolver.go 91.30% <0.00%> (-0.70%) ⬇️
pkg/apis/labs/v1alpha1/register.go 100.00% <0.00%> (ø)
pkg/apis/servicebinding/v1alpha2/register.go 100.00% <0.00%> (ø)
pkg/reconciler/servicebinding/resources/secret.go 100.00% <0.00%> (ø)
pkg/apis/labs/v1alpha1/provisionedservice_types.go 100.00% <0.00%> (ø)
...g/apis/servicebindinginternal/v1alpha2/register.go 100.00% <0.00%> (ø)
...apis/labs/v1alpha1/provisionedservice_lifecycle.go 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a232239...1f8c579. Read the comment docs.

Signed-off-by: Scott Andrews <andrewssc@vmware.com>
@scothis scothis merged commit 922ab98 into vmware-tanzu:main Sep 22, 2020
@scothis scothis deleted the dedup-envvar branch September 22, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required CLA not required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated support for SERVICE_BINDINGS_ROOT
2 participants