Multi-ServiceBindings for a single application #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #75 +/- ##
==========================================
+ Coverage 91.05% 91.37% +0.31%
==========================================
Files 18 18
Lines 548 568 +20
==========================================
+ Hits 499 519 +20
Misses 28 28
Partials 21 21
Continue to review full report at Codecov.
|
Better handle multiple ServiceBinding resources each targeting the same application resource. Depending on the order ServiceBindings are applied to the resource, the order of the resulting volumes, volume mounts and environment variables could differ. This difference could create churn on the API server for semantically equivalent resources. Now, we attempt to sort the entries injected into these lists for the ServiceBindings. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better handle multiple ServiceBinding resources each targeting the same
application resource. Depending on the order ServiceBindings are applied
to the resource, the order of the resulting volumes, volume mounts and
environment variables could differ. This difference could create churn
on the API server for semantically equivalent resources. Now, we attempt
to sort the entries injected into these lists for the ServiceBindings.
Resolves #66