Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs for v0.57.2 #1987

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Aug 29, 2024

What this PR does / why we need it:

https://sonobuoy.io/docs defaults to https://sonobuoy.io/docs/v0.57.2
and we missed adding content for v0.57.2.

This commits copies over the content from the main branch
and updates some metadata to point to v0.57.2.

Special notes for your reviewer:

This PR also has an additional fix to github actions to fix the goreleaser command. We download the latest version of goreleaser and it doesn't support the --rm-dist flag.

Release note:

NONE

Nikhita Raghunath added 2 commits August 29, 2024 16:50
With the latest goreleaser, using the `--rm-dist` flag leads to an error:

```
error=unknown flag: --rm-dist
```

Instead, the recommendation is to use `--clean` instead.

Signed-off-by: Nikhita Raghunath <nikhita.raghunath@broadcom.com>
https://sonobuoy.io/docs defaults to https://sonobuoy.io/docs/v0.57.2
and we missed adding content for v0.57.2.

This commits copies over the content from the `main` branch
and updates some metadata to point to v0.57.2.

Signed-off-by: Nikhita Raghunath <nikhita.raghunath@broadcom.com>
@nikhita
Copy link
Member Author

nikhita commented Aug 29, 2024

@mohitsharma-in can you review?

If you're encountering rate limit on this, you can use VMware-provided mirror with:

```bash
sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't have latest version on this might need to manually sync from dockerhub or update dockerhub ref

Then on running conformance:

```bash
sonobuoy run --sonobuoy-image projects.registry.vmware.com/sonobuoy/sonobuoy:<VERSION> --e2e-repo-config conformance-image-config.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably change this to sonobuoy/sonobuoy https://hub.docker.com/r/sonobuoy/sonobuoy/tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants