Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue#7731: add endpoint for GCP objectstore client #184

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

issue#7731: add endpoint for GCP objectstore client #184

wants to merge 1 commit into from
+7 −0

Conversation

chrislinan
Copy link

No description provided.

@chrislinan chrislinan mentioned this pull request May 9, 2024
Open
blackpiglet
blackpiglet previously approved these changes May 9, 2024
View reviewed changes
@blackpiglet blackpiglet dismissed their stale review May 9, 2024 09:09

Remove accidental approve.

@blackpiglet
Copy link
Collaborator

@chrislinan
The go module configuration is not update to date.

@blackpiglet
Copy link
Collaborator

Thanks for the update.
The code change looks good, but the Velero v1.14.0 waits for its RC.
Could we put this PR on hold until the GCP plugin's corresponding release is cut?

@chrislinan
Copy link
Author

Thanks for the update. The code change looks good, but the Velero v1.14.0 waits for its RC. Could we put this PR on hold until the GCP plugin's corresponding release is cut?

Yes, we could hold this PR. And I will open another PR for Velero to update documents and add this feature in docs.

@blackpiglet
Copy link
Collaborator

@chrislinan
Please help to squash the commits.

@linan-0115
add endpoint for GCP objectstore client
aff3d5f 
add endpoint for GCP objectstore client

Signed-off-by: William Li <william.li03@sap.com>

sign off

Signed-off-by: William Li <william.li03@sap.com>

format code

Signed-off-by: William Li <william.li03@sap.com>

remove wrong files

Signed-off-by: William Li <william.li03@sap.com>

update go module

Signed-off-by: William Li <william.li03@sap.com>

change endpoint key name

Signed-off-by: William Li <william.li03@sap.com>

update go module

Signed-off-by: William Li <william.li03@sap.com>
@anshulahuja98
Copy link

@blackpiglet can you trigger the CI
I don't have permission on this repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anshulahuja98 anshulahuja98 anshulahuja98 approved these changes

@shubham-pampattiwar shubham-pampattiwar Awaiting requested review from shubham-pampattiwar

@ywk253100 ywk253100 Awaiting requested review from ywk253100

@blackpiglet blackpiglet Awaiting requested review from blackpiglet

At least 2 approving reviews are required to merge this pull request.

Assignees

@chrislinan chrislinan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chrislinan @blackpiglet @anshulahuja98 @linan-0115