Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude "csinodes.storage.k8s.io" and "volumeattachments.storage.k8s.… #5064

Conversation

blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Jun 30, 2022

…io" from restore by default.

Signed-off-by: Xun Jiang jxun@vmware.com

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #4823

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@codecov-commenter
Copy link

codecov-commenter commented Jun 30, 2022

Codecov Report

Merging #5064 (d4fe031) into main (2778d54) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5064   +/-   ##
=======================================
  Coverage   41.30%   41.30%           
=======================================
  Files         210      210           
  Lines       18439    18439           
=======================================
  Hits         7616     7616           
  Misses      10253    10253           
  Partials      570      570           
Impacted Files Coverage Δ
pkg/controller/restore_controller.go 66.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2778d54...d4fe031. Read the comment docs.

…io" from backup and restore by default.

Signed-off-by: Xun Jiang <jxun@vmware.com>
@blackpiglet blackpiglet force-pushed the 4823-exclude-some-cluster-scope-resources branch from b08e9b1 to d4fe031 Compare June 30, 2022 03:29
@blackpiglet blackpiglet requested a review from reasonerjt June 30, 2022 03:41
@cmendible
Copy link

cmendible commented Aug 31, 2022

This is important. restoring CSINodes and VolumeAttachments breaks CSI driver behavior and can cause cluster stability issues.

Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
@reasonerjt
Copy link
Contributor

@blackpiglet should this be cherrypick to v1.9.x patch?

@blackpiglet blackpiglet added this to the v1.9.3 milestone Sep 29, 2022
@ywk253100 ywk253100 merged commit 3f3a505 into vmware-tanzu:main Sep 29, 2022
@blackpiglet blackpiglet removed this from the v1.9.3 milestone Sep 30, 2022
@blackpiglet blackpiglet deleted the 4823-exclude-some-cluster-scope-resources branch October 15, 2022 04:02
sshende-catalogicsoftware added a commit to catalogicsoftware/velero that referenced this pull request Oct 20, 2022
…io" from backup and restore by default. (vmware-tanzu#5064)

Signed-off-by: Xun Jiang <jxun@vmware.com>

Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
wenterjoy pushed a commit to wenterjoy/velero that referenced this pull request Dec 21, 2022
Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Clean backups after each test and fix exlude label test issue

1. Clean backups after each test to avoid exceeding limitation of storage capability during E2E test;
2. Fix exlude label test issue that namespace should not be included and excluded at the same time no matter by which way to config.

Signed-off-by: danfengl <danfengl@vmware.com>

Remove reference to non-existent doc

fixes vmware-tanzu#4923

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

Uploader Implementation: Kopia backup and restore

Signed-off-by: Ming <mqiu@vmware.com>

update upstream codes

Signed-off-by: Ming <mqiu@vmware.com>

refactor gc controller with kubebuilder

Signed-off-by: allenxu404 <qix2@vmware.com>

add OADP to adopters list

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

fix typo

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

check vsc null pointer

Signed-off-by: 李龙峰 <lilongfeng@inspur.com>

kopia lib

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Move the code in pkg/restic/common.go to the proper package

Move the code in pkg/restic/common.go to the proper package

Fixes vmware-tanzu#5243

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

Don't panic when storageClassName is not set in stateful sets

Signed-off-by: divolgin <dmitriy@replicated.com>

Controller refactor code modifications.

1. Add some refactored controllers initiation code into enabledRuntimeControllers.
2. Add reconciler struct initiation function for DownloadRequest and ServerStatusRequest controllers.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

equip gc controller with configurable frequency

Signed-off-by: allenxu404 <qix2@vmware.com>

Update the website of velero to refelct the change of PM (vmware-tanzu#5260)

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

Migrate backup sync controller from code-generator to kubebuilder (vmware-tanzu#5218)

* Migrate backup sync controller from code-generator to kubebuilder

1. use kubebuilder's reconcile logic to replace controller's old logic.
2. use ginkgo and gomega to replace testing.
3. modify BSL reconciler registration method.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

* Add Option for PeriodicalEnqueueSource.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>

Refactor BackupItemAction to backupitemaction/v1

Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com>

Add changelog

Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com>

Add missing file

Signed-off-by: Hoang, Phuong <phuong.n.hoang@dell.com>

renamed update files so that protoc is run before CRD update.

If generating protoc go files from scratch, `make update` fails if
CRD generation happens first, since the protoc-generated
files are imported by the api go files.
protoc generation needs to happen earlier.

Signed-off-by: Scott Seago <sseago@redhat.com>

updated to newer protoc/protoc-gen-go

Signed-off-by: Scott Seago <sseago@redhat.com>

Updated plugin/framework server files to cope with protoc changes

Signed-off-by: Scott Seago <sseago@redhat.com>

some additional debug logs

Signed-off-by: Scott Seago <sseago@redhat.com>

fix edge cases for already exists resources

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog file

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

update changelog filename

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

change log level and error type

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Uploader Implementation: Restic backup and restore

Signed-off-by: Ming <mqiu@vmware.com>

merge upstream code

Signed-off-by: Ming <mqiu@vmware.com>

Add enable API group on k8s resources E2E test upon issue vmware-tanzu#5146

Signed-off-by: danfengl <danfengl@vmware.com>

Check for empty ns list before checking nslist[0]

In determining whether a backup includes all namespaces, item_collector
checks for an empty string in the first element of the ns list. If processing
includes+excludes results in an empty list, treat this as another case
of a not-all-namespaces backup rather than crashing velero.

Signed-off-by: Scott Seago <sseago@redhat.com>

Kopia Pod Volume Backup/Restore (vmware-tanzu#5259)

* kopia pvbr

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

chore: remove duplicate word in comments

Signed-off-by: Abirdcfly <fp544037857@gmail.com>

add CSISnapshotTimeout for describe backup

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

kopia pvbr smoking test changes

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

trim isAlreadyExistsError for restore

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

refactor repo ensurer

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add credentials to volume snapshot locations.

This is analogous to the BSL creds work that was done previously, but for VSLs instead.

Signed-off-by: Scott Seago <sseago@redhat.com>

fix issue 4874

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

issue fix 4874 update

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

add shorthand for labels columns

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Fix PVB finds wrong parent snapshot

Signed-off-by: Ming <mqiu@vmware.com>

Fix restore cmd extraflag overwrite bug

Signed-off-by: Ming <mqiu@vmware.com>

Don't move velero v1 plugins to new proto dir

To preserve backwards compatibility, don't move velero
v1 plugins to new proto dir.

Signed-off-by: Scott Seago <sseago@redhat.com>

Change the status of restore to completed from partially failed when restore empty backup

Signed-off-by: allenxu404 <qix2@vmware.com>

plugin/clientmgmt refactoring for BackupItemAction v1

Refactors the clientmgmt package to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Signed-off-by: Scott Seago <sseago@redhat.com>

plugin/framework refactoring for BackupItemAction v1

Refactors the framework  package to implement the plugin versioning changes
needed for BIA v1 and overall package refactoring to support plugin versions
in different packages. This should be all that's needed to move on to
v2 for BackupItemAction. The remaining plugin types still need similar
refactoring to what's being done here for BIA before attempting a
v2 implementation.

Signed-off-by: Scott Seago <sseago@redhat.com>

Remove github.com/apex/log logger.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

cancel downloadRequest checkFunc if timeout passed

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

fix issue 5352

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

fix issue 5358

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Clarify the help message for the default value of parameter --snapshot-volumes, when it's not set.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Support pause/unpause schedules

Support pause/unpause schedule

Fixes vmware-tanzu#2363

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

RestoreItemAction v1 refactoring for plugin api versioning

Signed-off-by: Scott Seago <sseago@redhat.com>

add useOwnerReferencesInBackup field doc

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Fix issue of fail to get command output for test verification

When running velero backup/restore command, if the command result is "PartiallyFailed", it won't reture error as design, but we do need to know the debug information to figure out the reason, so the command output is needed to get the command result, then further action will be taken.

Signed-off-by: danfengl <danfengl@vmware.com>

rename pvbr param (vmware-tanzu#5370)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

plugin versioning v1 refactor for VolumeSnapshotter

Signed-off-by: Scott Seago <sseago@redhat.com>

Remove snapshot related lister, informer and client from backup controller. (vmware-tanzu#5299)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

 Add schedule backup timing E2E test

Signed-off-by: danfengl <danfengl@vmware.com>

fix issue 5386

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Added backupController's UT to test the prepareBackupRequest() method BackupStorageLocation processing logic

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>

add change log

Signed-off-by: Niu Lechuan <lechuan.niu@daocloud.io>

Add Kopia support for Velero installation in E2E test

Signed-off-by: danfengl <danfengl@vmware.com>

Add backup opt-in/opt-out E2E test

Signed-off-by: danfengl <danfengl@vmware.com>

Fix Test_prepareBackupRequest_BackupStorageLocation UT failure.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Fix restore error with flag namespace-mappings (vmware-tanzu#5377)

Signed-off-by: Ming <mqiu@vmware.com>

A little note about TTL expiration

I think is necessary this little comment about TTL expiration, because it can be confusing when the expiration time has passed and the data allocated and the snapshots are not erased at that time.

Signed-off-by: Aaron Arias <33655005+aaronariasperez@users.noreply.github.com>

Add backup status checking schedule controller. (vmware-tanzu#5283)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>

Exclude "csinodes.storage.k8s.io" and "volumeattachments.storage.k8s.io" from backup and restore by default. (vmware-tanzu#5064)

Signed-off-by: Xun Jiang <jxun@vmware.com>

Signed-off-by: Xun Jiang <jxun@vmware.com>
Signed-off-by: Xun Jiang/Bruce Jiang <59276555+blackpiglet@users.noreply.github.com>

Fix issues of E2E test for API group, migration and pv opt-out backup

1. One of API group test failed due to other PR with fix for treat PartiallyFailed as failure to collect debugbundle without wrap the origin error;
2. Fix migration test issue of wrong velero cli for backup commmand;
3. Fix wrong pararmeter name issue for pv opt-out backup test.

Signed-off-by: danfengl <danfengl@vmware.com>

update velero using klog to version v2.9.0 (vmware-tanzu#5396)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>

Change B/R describe cli to support kopia

Signed-off-by: allenxu404 <qix2@vmware.com>

Update Maintainers with the new PM pradeepkchaturvedi

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Maintainers with the new PM pradeepkchaturvedi

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

rename daemonset (vmware-tanzu#5390)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Skip the exclusion check for additional resources returned by BIA

This commit provides a simple contract that if the BackupItemAction
plugin sets an annotation in a resource it has handled, the additional
items will considered "must include" i.e. each of them will skip the
"include-exclude" filter, such that the plugin developer can make sure
they are included in the backup disregarding the filter setting in the
bakcup CR.

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

moved RIA execute input/output structs back to velero package

The RIA refactoring moved velero.RestoreItemAction into a separate
(restoreitemaction) v1 package. Unfortunately, this change would require
plugins to make code changes to locate the RestoreItemActionExecuteInput
and RestoreItemActionExecuteOutput structs.

This commit restores those structs to the original velero package, leaving
just the RestoreItemAction interface in the new v1 package.

Signed-off-by: Scott Seago <sseago@redhat.com>

fix-ctx-issue

1. Fix issue of kubectl client and server mismatch version in GitAction E2E job, refer to elastic/cloud-on-k8s#4737;
2. Adapt to the changing of keyword for involing Kpoia as fs backupper, new installtion breaked upgrade and migration tests;
3. Accept multi-labels of Ginkgo focus as input of E2E make command;
4. Distinguish workload namespace from each tests;
5. Fix issues of not using Velero util to perform Velero commands;
6. Add snapshot test case for NamespaceMapping E2E test;
7. Collect debug bundle after catching error of Velero backup or restore command;
Signed-off-by: danfengl <danfengl@vmware.com>

Pod Volume Backup/Restore Refactor: Rename Init Helper (vmware-tanzu#5432)

* restore helper refactor

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

* resolve codespell

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

remove restic from code

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Change subcommand restic to repo

Signed-off-by: allenxu404 <qix2@vmware.com>

Bump Go to 1.18

Signed-off-by: Gábor Lipták <gliptak@gmail.com>

upgrade velero docker image

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

fix lint errors

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

fix lint loop iterator problem

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add CSI VolumeSnapshot client back. (vmware-tanzu#5449)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Add nil check before execution of csi snapshot delete

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

add changelog

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

change CSISnapshotTimeout from point to normal var

Signed-off-by: cleverhu <shouping.hu@daocloud.io>

Fix CVE-2022-27191

https://nvd.nist.gov/vuln/detail/CVE-2022-27191
updates to:
  * golang.org/x/crypto v0.0.0-20220315160706-3147a52a75dd
adds:
  * golang.org/x/net v0.0.0-20211112202133-69e39bad7dc2

Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>

Resolve gopkg.in/yaml.v3 vulnerabilities

as shown from https://security.snyk.io/package/golang/gopkg.in%2Fyaml.v3

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>

increase ensure restic repository timeout (vmware-tanzu#5335)

Signed-off-by: Shubham Pampattiwar <spampatt@redhat.com>

Fix label naming  issue for restore helper (vmware-tanzu#5469)

Signed-off-by: danfengl <danfengl@vmware.com>

Add more nil pointer check for CSI related code in backup controller. (vmware-tanzu#5388)

Add some corner cases checking for CSI snapshot in backup controller.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

update k8s.io dependencies to 0.24.0
* This also required an update to use github.com/bombsimon/logrusr/v3
* 'WithClusterName' removed as per the k8s doc reasoning:
* https://github.com/kubernetes/apimachinery/blob/release-1.24/pkg/apis/meta/v1/types.go\#L257-L259
* ('ClusterName was a legacy field that was always cleared by the system and never used')
* Test was updated accordingly

Signed-off-by: Kira Boyle <kira@replicated.com>

Change name of changelog file

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

Trivial correction to 1.7 upgrade instructions

The container name for the aws plugin is `velero-plugin-for-aws`. There was an extra `velero-` prefix in the doc.

Signed-off-by: Dave Pedu <dave@davepedu.com>

Remove redundancy code block left by vmware-tanzu#5388. (vmware-tanzu#5483)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

refactor pvbr doc

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add credential file store in the backup deletion controller.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

fix backup failure with self-signed certification

Signed-off-by: Ming <mqiu@vmware.com>

remove restic in docs (vmware-tanzu#5499)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

repo config for s3 compatible store

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

issue fix 5505

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

fix restic backup progress error

Signed-off-by: Ming <mqiu@vmware.com>

Fix GCP StorageClass used for E2E testing's YAML syntax error. (vmware-tanzu#5536)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>

Enhance the restore priorities list to support specifying the low prioritized resources that need to be restored in the last

Enhance the restore priorities list to support specifying the low prioritized resources that need to be r
estored in the last

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

feat: dependabot workflow automation for updating dependency

Signed-off-by: Pratik Raj <Rajpratik71@gmail.com>

Fix pointer deference to string in error message

Signed-off-by: Faizan Ahmad <faizan@obmondo.com>

add VSL credentials documentation.

Signed-off-by: Scott Seago <sseago@redhat.com>

Add v1.10 velero upgrade doc

Signed-off-by: Ming <mqiu@vmware.com>

fix main TOC for 1.10

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

add note for left over resources

Signed-off-by: Ming <mqiu@vmware.com>

Modify dependabot rules by only fix security issues

Signed-off-by: Ming <mqiu@vmware.com>

remove gofrs uuid

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Upload Velero build package saved from build image to Google cloud storage

Signed-off-by: danfengl <danfengl@vmware.com>

Fix controller problematic log output

Signed-off-by: Ming <mqiu@vmware.com>

Add compile restic binary for CVE fix

Signed-off-by: Ming <mqiu@vmware.com>

Rename secret for Google cloud storage

Signed-off-by: danfengl <danfengl@vmware.com>

Fix restic cross platform compile

Signed-off-by: Ming <mqiu@vmware.com>

debug opt in out

Signed-off-by: danfengl <danfengl@vmware.com>

Update upgrade test for 1.10

Signed-off-by: danfengl <danfengl@vmware.com>

Save vvelero image tarball only for velero namespace in docker registry (vmware-tanzu#5581)

Signed-off-by: danfengl <danfengl@vmware.com>

1.10 changelog and doc (vmware-tanzu#5583)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

update 1.10 readme

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add Velero behind proxy document.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Add Velero File System Backup Performance Guide

Signed-off-by: Ming <mqiu@vmware.com>

update 1.10 release notes

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Update the Valero channel hash-name for Kubernetes Slack.

Signed-off-by: Nikhil Maheshwari <nikhil.m2498@gmail.com>

[Main Cherry-Pick]Enhance upgrade velero bash script

Signed-off-by: Ming <mqiu@vmware.com>

Add pause/unpause schedule e2e test (vmware-tanzu#5609)

Signed-off-by: danfengl <danfengl@vmware.com>

Restore ClusterBootstrap before Cluster

Restore ClusterBootstrap before Cluster otherwise a new default ClusterBootstrap object is create for the cluster

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

remove versions from kind matrix

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Bump goreleaser to v1.12.3

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>

Fix git action issue for setup-gcloud

Signed-off-by: danfengl <danfengl@vmware.com>

Add verification for CRD installation

Signed-off-by: danfengl <danfengl@vmware.com>

Update the api-types doc

This commit makes update to the update api-types docs to add missing
fields.
It also includes misc changes to the inline comment, and a change to
Dockerfile to make sure the build-image works on mac

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

cut v1.10 docs on main

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add sleep before backing up new born CRD

Signed-off-by: danfengl <danfengl@vmware.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

try to fix link check error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

reversed the order of name and kind

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

try to fix link check error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

Fix CVEs scanned by trivy

Signed-off-by: Ming <mqiu@vmware.com>

Fix links to compatibility matrix

Signed-off-by: Lukas Hass <lukas@slucky.de>

Update Velero and k8s version compatibility matrix.

Due to CSIDriver is checked for Restic volume mounting path, and CSIDriver is GA and moved to storage v1 group in k8s v1.18, so update Velero v1.8, v1.9 and v1.10 compatible k8s version to 1.18-latest.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Item action progress monitoring design

This design combines the requirements for the previously-merged
Upload Progress Monitoring design with the requirements for the
(not submitted but discussed in meetings and slack) proposed asynchronous
item action plugins into one integrated proposal.

Signed-off-by: Scott Seago <sseago@redhat.com>

BackupItemAction v2 design

This includes necessary changes to support async item action monitoring.

Signed-off-by: Scott Seago <sseago@redhat.com>

reversethe order of name and kind

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

RestoreItemAction v2 design

Signed-off-by: Scott Seago <sseago@redhat.com>

VolumeSnapshotter v2 API design

Signed-off-by: Scott Seago <sseago@redhat.com>

Prevent nil panic on exec restore hooks (vmware-tanzu#5675)

* Prevent nil panic on exec restore hooks

Signed-off-by: Dylan Murray <dymurray@redhat.com>

refactor pvbr doc

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add credential file store in the backup deletion controller.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

fix backup failure with self-signed certification

Signed-off-by: Ming <mqiu@vmware.com>

remove restic in docs (vmware-tanzu#5499)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

repo config for s3 compatible store

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

issue fix 5505

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

fix restic backup progress error

Signed-off-by: Ming <mqiu@vmware.com>

Fix GCP StorageClass used for E2E testing's YAML syntax error. (vmware-tanzu#5536)

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>
Co-authored-by: Xun Jiang <blackpiglet@gmail.com>

Enhance the restore priorities list to support specifying the low prioritized resources that need to be restored in the last

Enhance the restore priorities list to support specifying the low prioritized resources that need to be r
estored in the last

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

Update Community meetings times

vmware-tanzu#5091

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

feat: dependabot workflow automation for updating dependency

Signed-off-by: Pratik Raj <Rajpratik71@gmail.com>

Fix pointer deference to string in error message

Signed-off-by: Faizan Ahmad <faizan@obmondo.com>

add VSL credentials documentation.

Signed-off-by: Scott Seago <sseago@redhat.com>

Add v1.10 velero upgrade doc

Signed-off-by: Ming <mqiu@vmware.com>

fix main TOC for 1.10

Signed-off-by: OrlinVasilev <ovasilev@vmware.com>

add note for left over resources

Signed-off-by: Ming <mqiu@vmware.com>

Modify dependabot rules by only fix security issues

Signed-off-by: Ming <mqiu@vmware.com>

remove gofrs uuid

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Upload Velero build package saved from build image to Google cloud storage

Signed-off-by: danfengl <danfengl@vmware.com>

Fix controller problematic log output

Signed-off-by: Ming <mqiu@vmware.com>

Add compile restic binary for CVE fix

Signed-off-by: Ming <mqiu@vmware.com>

Rename secret for Google cloud storage

Signed-off-by: danfengl <danfengl@vmware.com>

Fix restic cross platform compile

Signed-off-by: Ming <mqiu@vmware.com>

debug opt in out

Signed-off-by: danfengl <danfengl@vmware.com>

Update upgrade test for 1.10

Signed-off-by: danfengl <danfengl@vmware.com>

Save vvelero image tarball only for velero namespace in docker registry (vmware-tanzu#5581)

Signed-off-by: danfengl <danfengl@vmware.com>

1.10 changelog and doc (vmware-tanzu#5583)

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

update 1.10 readme

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add Velero behind proxy document.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Add Velero File System Backup Performance Guide

Signed-off-by: Ming <mqiu@vmware.com>

update 1.10 release notes

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Update the Valero channel hash-name for Kubernetes Slack.

Signed-off-by: Nikhil Maheshwari <nikhil.m2498@gmail.com>

[Main Cherry-Pick]Enhance upgrade velero bash script

Signed-off-by: Ming <mqiu@vmware.com>

Add pause/unpause schedule e2e test (vmware-tanzu#5609)

Signed-off-by: danfengl <danfengl@vmware.com>

Restore ClusterBootstrap before Cluster

Restore ClusterBootstrap before Cluster otherwise a new default ClusterBootstrap object is create for the cluster

Signed-off-by: Wenkai Yin(尹文开) <yinw@vmware.com>

remove versions from kind matrix

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Bump goreleaser to v1.12.3

Signed-off-by: JenTing Hsiao <hsiaoairplane@gmail.com>

Fix git action issue for setup-gcloud

Signed-off-by: danfengl <danfengl@vmware.com>

Add verification for CRD installation

Signed-off-by: danfengl <danfengl@vmware.com>

Update the api-types doc

This commit makes update to the update api-types docs to add missing
fields.
It also includes misc changes to the inline comment, and a change to
Dockerfile to make sure the build-image works on mac

Signed-off-by: Daniel Jiang <jiangd@vmware.com>

cut v1.10 docs on main

Signed-off-by: Lyndon-Li <lyonghui@vmware.com>

Add sleep before backing up new born CRD

Signed-off-by: danfengl <danfengl@vmware.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

try to fix link check error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

reversed the order of name and kind

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image repository by configmap

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct changelog name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

modified according review comments

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

change image replace rule to match all the cases

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

use single bit "," as the delimiter

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

removed  section of juding DELIMITER_KEY

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

corrected code spell error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

 remove "Job" from the conditional

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

correct plugin name

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

try to fix link check error

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

Fix CVEs scanned by trivy

Signed-off-by: Ming <mqiu@vmware.com>

Fix links to compatibility matrix

Signed-off-by: Lukas Hass <lukas@slucky.de>

Update Velero and k8s version compatibility matrix.

Due to CSIDriver is checked for Restic volume mounting path, and CSIDriver is GA and moved to storage v1 group in k8s v1.18, so update Velero v1.8, v1.9 and v1.10 compatible k8s version to 1.18-latest.

Signed-off-by: Xun Jiang <blackpiglet@gmail.com>

Item action progress monitoring design

This design combines the requirements for the previously-merged
Upload Progress Monitoring design with the requirements for the
(not submitted but discussed in meetings and slack) proposed asynchronous
item action plugins into one integrated proposal.

Signed-off-by: Scott Seago <sseago@redhat.com>

BackupItemAction v2 design

This includes necessary changes to support async item action monitoring.

Signed-off-by: Scott Seago <sseago@redhat.com>

reversethe order of name and kind

Signed-off-by: wenterjoy <zhaoxin26@lenovo.com>

RestoreItemAction v2 design

Signed-off-by: Scott Seago <sseago@redhat.com>

VolumeSnapshotter v2 API design

Signed-off-by: Scott Seago <sseago@redhat.com>

Prevent nil panic on exec restore hooks (vmware-tanzu#5675)

* Prevent nil panic on exec restore hooks

Signed-off-by: Dylan Murray <dymurray@redhat.com>

[Cherry-Pick]Fix error with Restic backup empty volumes

Signed-off-by: Ming <mqiu@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude CSINode and VolumeAttachments by default?
5 participants